From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1S0y2E-0005Ie-6e for openembedded-core@lists.openembedded.org; Fri, 24 Feb 2012 17:30:18 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q1OGLtF5008497 for ; Fri, 24 Feb 2012 16:21:55 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 08091-05 for ; Fri, 24 Feb 2012 16:21:47 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q1OGLhmn008482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 24 Feb 2012 16:21:43 GMT Message-ID: <1330100504.5477.6.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Fri, 24 Feb 2012 16:21:44 +0000 In-Reply-To: References: X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH 3/4] default-distrovars: Add empty weak definition for DISTRO variable X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 16:30:18 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2012-02-23 at 19:33 -0800, Khem Raj wrote: > Signed-off-by: Khem Raj > --- > meta/conf/distro/include/default-distrovars.inc | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc > index 16b3108..dba204e 100644 > --- a/meta/conf/distro/include/default-distrovars.inc > +++ b/meta/conf/distro/include/default-distrovars.inc > @@ -41,6 +41,13 @@ NO32LIBS ??= "1" > > # Default to emitting logfiles if a build fails. > BBINCLUDELOGS ??= "yes" > + > +# dummy distro related variables > +# they should be overridden by real distros > +# these fallbacks only serve the purpose of > +# oe-core standalone testability > + > +DISTRO ??= "" > SDK_VERSION ??= "oe-core.0" > DISTRO_VERSION ??= "oe-core.0" Why do we need this? The commit message tells me what you're doing but not why. I'm really getting frustrated with one line commit messages with no details. I don't think we should need this either, I'm not sure I like the change. The whole idea was OE-Core could run "distroless". Cheers, Richard