Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Leon Woestenberg <sidebranch.openembedded@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: bitbake parsing of IMAGE_INSTALL += # tslib mtd-utils" extremely user unfriendly.
Date: Sun, 26 Feb 2012 23:04:20 +0000	[thread overview]
Message-ID: <1330297460.31855.24.camel@ted> (raw)
In-Reply-To: <CAMvUbCybn5jKbVJMdsrY7SpUoGjku3MwgOU+0WvQ+4LBituWvA@mail.gmail.com>

On Sun, 2012-02-26 at 20:35 +0100, Leon Woestenberg wrote:
> On Sun, Feb 26, 2012 at 2:06 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>         On Mon, 2012-02-20 at 23:00 +0100, Leon Woestenberg wrote:
>         > bitbake can really braindump on us when we insert typo's.
>          The result
>         > of bitbake 1.14 parsing this one wasn't pleasant:
>         >
>         > IMAGE_INSTALL += # tslib mtd-utils"
>         >
>         > (Yes, it's a typo. No, I wouldn't expect bitbake to give me
>         that much
>         > output :) )
>
>         I agree we need to fix that. I've proposed a patch to bitbake
>         which
>         would allow detection and a better error message for something
>         like this
>         by enforcing quoting of variables. It is a major change in
>         bitbake's
>         behaviour though so I'm taking feedback on whether we should
>         make the
>         change.
>
> If we focus on our user interface view, that would mean this will no
> longer work:
>
> SOME_BINARY_VARIABLE = 1
>
> but that might be a better compromise than what we currently have.

FWIW, internally, that is still a string even if it looks a bit like a
binary value so there is no effective change.

Cheers,

Richard





      reply	other threads:[~2012-02-26 23:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 22:00 bitbake parsing of IMAGE_INSTALL += # tslib mtd-utils" extremely user unfriendly Leon Woestenberg
2012-02-21 12:56 ` Richard Purdie
2012-02-23 15:30   ` Eric Bénard
2012-02-23 15:32     ` Paul Eggleton
2012-02-23 15:38       ` Paul Eggleton
2012-02-23 16:06         ` Eric Bénard
2012-02-26 12:27     ` Richard Purdie
2012-02-26 13:06 ` Richard Purdie
2012-02-26 19:35   ` Leon Woestenberg
2012-02-26 23:04     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330297460.31855.24.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sidebranch.openembedded@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox