From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH v2] tcl 8.5.11: fix packaging
Date: Tue, 28 Feb 2012 13:36:18 +0000 [thread overview]
Message-ID: <1330436178.9185.117.camel@ted> (raw)
In-Reply-To: <1330435555-21482-1-git-send-email-koen@dominion.thruhere.net>
On Tue, 2012-02-28 at 14:25 +0100, Koen Kooi wrote:
> Include /usr/lib/tcl8 for the msgcat and test module, force dependency on tcl-lib since shlibs isn't picking it up.
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>
> Changes from v1: ${PN}-lib -> tcl-lib
>
> meta/recipes-devtools/tcltk/tcl_8.5.11.bb | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.11.bb b/meta/recipes-devtools/tcltk/tcl_8.5.11.bb
> index 146021a..ef1b76d 100644
> --- a/meta/recipes-devtools/tcltk/tcl_8.5.11.bb
> +++ b/meta/recipes-devtools/tcltk/tcl_8.5.11.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
> file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
> "
>
> -PR = "r2"
> +PR = "r4"
>
> BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
> file://tcl-add-soname.patch"
> @@ -57,9 +57,12 @@ do_install() {
> done
> }
>
> -PACKAGES =+ "${PN}-lib"
> -FILES_${PN}-lib = "${libdir}/libtcl8.5.so*"
> -FILES_${PN} += "${prefix}/lib/tcl8.5"
> +PACKAGES =+ "tcl-lib"
> +FILES_tcl-lib = "${libdir}/libtcl8.5.so*"
> +FILES_${PN} += "${prefix}/lib/tcl8.5 ${prefix}/lib/tcl8"
> FILES_${PN}-dev += "${libdir}/tclConfig.sh"
>
> +# isn't getting picked up by shlibs code
> +RDEPENDS_${PN} += "tcl-lib"
> +
> BBCLASSEXTEND = "native"
I'd merged the original so I've squashed a revert of that with this
commit and pushed that :/.
I've also realised we could have used BPN here but I think this fix is
fine.
Cheers,
Richard
prev parent reply other threads:[~2012-02-28 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 13:25 [PATCH v2] tcl 8.5.11: fix packaging Koen Kooi
2012-02-28 13:36 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330436178.9185.117.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox