Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] image_types.bbclass: properly support IMAGE_LINK_NAME as empty
Date: Wed, 29 Feb 2012 12:56:15 +0000	[thread overview]
Message-ID: <1330520175.24508.39.camel@ted> (raw)
In-Reply-To: <515e5d34c437e37115e4005738a2b2c8055508cf.1330494042.git.otavio@ossystems.com.br>

On Wed, 2012-02-29 at 05:41 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/classes/image_types.bbclass |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 74071c1..f9ed49f 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -25,7 +25,9 @@ def get_imagecmds(d):
>              types.append("ext3")
>          types.remove("live")
>  
> -    cmds += "	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
> +    if len(d.getVar('IMAGE_LINK_NAME', True)) > 0:
> +        cmds += "	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.*"
> +

I took this but I removed the unneeded len() above.

Cheers,

Richard




  reply	other threads:[~2012-02-29 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  5:41 [PATCH 0/3] Pending patches from O.S. Systems' tree Otavio Salvador
2012-02-29  5:41 ` [PATCH 1/3] image.bbclass: do not create image manifest link if IMAGE_LINK_NAME is empty Otavio Salvador
2012-02-29  5:41 ` [PATCH 2/3] image_types.bbclass: properly support IMAGE_LINK_NAME as empty Otavio Salvador
2012-02-29 12:56   ` Richard Purdie [this message]
2012-02-29  5:41 ` [PATCH 3/3] image_types.bbclass: fix bzip2 and xz compression commands Otavio Salvador
2012-02-29 13:00 ` [PATCH 0/3] Pending patches from O.S. Systems' tree Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330520175.24508.39.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox