From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1S6HY8-0002Sd-Uu; Sat, 10 Mar 2012 09:21:13 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2A8CWD9023071; Sat, 10 Mar 2012 08:12:32 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22481-03; Sat, 10 Mar 2012 08:12:27 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2A8CMNg023063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 10 Mar 2012 08:12:24 GMT Message-ID: <1331142081.25887.42.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer In-Reply-To: <1331076055-15262-1-git-send-email-msm@freescale.com> References: <1331076055-15262-1-git-send-email-msm@freescale.com> Date: Wed, 07 Mar 2012 09:41:21 -0800 Mime-Version: 1.0 X-Mailer: Evolution 3.2.2- X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core@openembedded.org Subject: Re: [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2012 08:21:13 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2012-03-06 at 17:20 -0600, Matthew McClintock wrote: > We can use the default value for TUNE_PKGARCH, and now we just > append "-nf" if TARGET_FPU is fpu-soft > > Signed-off-by: Matthew McClintock > --- > meta/conf/machine/include/powerpc/arch-powerpc.inc | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc > index c9b2829..abd72ed 100644 > --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc > +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc > @@ -18,10 +18,8 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)} > > ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}" > > -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}" > - > -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}" > -TUNE_PKGARCH ?= "${PPCPKGARCH}" > +PPCPKGSFX_FPU = "${@['', '-nf'][bb.data.getVar('TARGET_FPU',d,1) in ['fpu-soft']]}" bb.data is deprecated and we should translate: bb.data.getVar('TARGET_FPU',d,1) -> d.getVar('TARGET_FPU', True) Cheers, Richard