From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][RFC] bitbake.conf: use empty SRC_URI by default
Date: Fri, 09 Mar 2012 06:25:51 -0800 [thread overview]
Message-ID: <1331303151.3006.43.camel@ted> (raw)
In-Reply-To: <4F59BA50.3010309@linux.intel.com>
On Fri, 2012-03-09 at 00:07 -0800, Saul Wold wrote:
> On 03/08/2012 01:38 PM, Andreas Oberritter wrote:
> > On 08.03.2012 03:51, Andreas Oberritter wrote:
> >> * Otherwise, recipes that only append to SRC_URI instead of
> >> overwriting it will get the full path of the recipe written
> >> into the Source: field of the package.
> >>
> >> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
> >> ---
> >> * I haven't tested this yet, I don't know whether there
> >> are any caveeats. What's the purpose of having ${FILE}
> >> in there, anyway?
> >
> > Richard, did you commit this by accident? In the meantime I've started a
> > clean build with this patch applied and noticed eglibc-locale failing,
> > because opkg-build complains about a missing "Source" field.
> >
> Agreed, this seems to have been committed by accident, we see the same
> failures on the Autobuilder.
I meant to do some local testing but it ended up getting merged, sorry
about that. Since there weren't too many issues on the autobuilder, I
pushed a follow up which sets Source to be "None" rather than unset and
the last set of builds are looking pretty green.
Cheers,
Richard
prev parent reply other threads:[~2012-03-09 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 2:51 [PATCH][RFC] bitbake.conf: use empty SRC_URI by default Andreas Oberritter
2012-03-08 21:38 ` Andreas Oberritter
2012-03-09 8:07 ` Saul Wold
2012-03-09 14:25 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331303151.3006.43.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox