From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] ppp: Clean up PACKAGES vs. variable mismatch and drop unused RDEPENDS
Date: Tue, 13 Mar 2012 15:09:15 +0000 [thread overview]
Message-ID: <1331651355.17122.6.camel@ted> (raw)
The RPDEPENDS format is wrong and couldn't have been doing anything useful. The
mismatch between PACKAGES and the DESCRIPTION_* and FILES_* variable names could
confuse the system under certain conditions so this is a good cleanup to make.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/recipes-connectivity/ppp/ppp_2.4.5.bb b/meta/recipes-connectivity/ppp/ppp_2.4.5.bb
index 13216e3..9232e6f 100644
--- a/meta/recipes-connectivity/ppp/ppp_2.4.5.bb
+++ b/meta/recipes-connectivity/ppp/ppp_2.4.5.bb
@@ -52,7 +52,7 @@ do_install_append () {
}
CONFFILES_${PN} = "${sysconfdir}/ppp/pap-secrets ${sysconfdir}/ppp/chap-secrets ${sysconfdir}/ppp/options"
-PACKAGES =+ "ppp-oa ppp-oe ppp-radius ppp-winbind ppp-minconn ppp-password ppp-l2tp ppp-tools"
+PACKAGES =+ "${PN}-oa ${PN}-oe ${PN}-radius ${PN}-winbind ${PN}-minconn ${PN}-password ${PN}-l2tp ${PN}-tools"
FILES_${PN} = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd"
FILES_${PN}_nylon = "${sysconfdir} ${bindir} ${sbindir}/chat ${sbindir}/pppd ${sbindir}/tdbread"
FILES_${PN}-dbg += "${libdir}/pppd/${PV}/.debug"
@@ -64,15 +64,14 @@ FILES_${PN}-minconn = "${libdir}/pppd/${PV}/minconn.so"
FILES_${PN}-password = "${libdir}/pppd/${PV}/pass*.so"
FILES_${PN}-l2tp = "${libdir}/pppd/${PV}/*l2tp.so"
FILES_${PN}-tools = "${sbindir}/pppstats ${sbindir}/pppdump"
-DESCRIPTION_ppp-oa = "Plugin for PPP needed for PPP-over-ATM"
-DESCRIPTION_ppp-oe = "Plugin for PPP needed for PPP-over-Ethernet"
-DESCRIPTION_ppp-radius = "Plugin for PPP that are related to RADIUS"
-DESCRIPTION_ppp-winbind = "Plugin for PPP to authenticate against Samba or Windows"
-DESCRIPTION_ppp-minconn = "Plugin for PPP to specify a minimum connect time before the idle timeout applies"
-DESCRIPTION_ppp-password = "Plugin for PPP to get passwords via a pipe"
-DESCRIPTION_ppp-l2tp = "Plugin for PPP for l2tp support"
-DESCRIPTION_ppp-tools = "The pppdump and pppstats utitilities"
-RDEPENDS_ppp_minconn += "libpcap0.8"
+DESCRIPTION_${PN}-oa = "Plugin for PPP needed for PPP-over-ATM"
+DESCRIPTION_${PN}-oe = "Plugin for PPP needed for PPP-over-Ethernet"
+DESCRIPTION_${PN}-radius = "Plugin for PPP that are related to RADIUS"
+DESCRIPTION_${PN}-winbind = "Plugin for PPP to authenticate against Samba or Windows"
+DESCRIPTION_${PN}-minconn = "Plugin for PPP to specify a minimum connect time before the idle timeout applies"
+DESCRIPTION_${PN}-password = "Plugin for PPP to get passwords via a pipe"
+DESCRIPTION_${PN}-l2tp = "Plugin for PPP for l2tp support"
+DESCRIPTION_${PN}-tools = "The pppdump and pppstats utitilities"
pkg_postinst_${PN}() {
if test "x$D" != "x"; then
reply other threads:[~2012-03-13 15:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331651355.17122.6.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox