From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] package.bbclass: create debugsources.list if it doesn't exist
Date: Tue, 13 Mar 2012 17:15:43 +0000 [thread overview]
Message-ID: <1331658943.18586.2.camel@ted> (raw)
In-Reply-To: <195b9ad9e78ea2355c0a5594436293e803bd460e.1331605922.git.liezhi.yang@windriver.com>
On Tue, 2012-03-13 at 10:50 +0800, Robert Yang wrote:
> Serval pkg's debug pkg is null, so the find-debuginfo.sh would not
> generate the ${WORKDIR}/debugsources.list, but the processdebugsrc
> always need it, there are a few such errors currently:(53 pkgs have such
> errors in a core-image-sato build):
>
> log.do_package:sort: open failed: debugsources.list: No such file or directory
>
> Create debugsources.list if it doesn't exist would fix this problem.
Why can't we modify the code that uses debugsources.list not to get
upset if it doesn't exist?
This change seems a little backwards to me...
Cheers,
Richard
> [YOCTO #2076]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/classes/package.bbclass | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 9b6862d..8e76ef8 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -243,6 +243,11 @@ def splitfile2(debugsrcdir, d):
> workparentdir = os.path.dirname(workdir)
> workbasedir = os.path.basename(workdir)
> sourcefile = d.expand("${WORKDIR}/debugsources.list")
> + # There is no debugsources.list when the debug pkg is null, but the
> + # processdebugsrc needs it, so create one if it doesn't exist.
> + if not os.path.isfile(sourcefile):
> + f = open(sourcefile, 'w')
> + f.close()
>
> if debugsrcdir:
> nosuchdir = []
next prev parent reply other threads:[~2012-03-13 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 2:50 [PATCH 0/1] package.bbclass: create debugsources.list if it doesn't exist Robert Yang
2012-03-13 2:50 ` [PATCH 1/1] " Robert Yang
2012-03-13 17:15 ` Richard Purdie [this message]
2012-03-14 0:49 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331658943.18586.2.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox