Re: [PATCH 6/7] python-pycurl: fix packaging warnings

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2012-03-17 at 00:35 +0000, Kamble, Nitin A wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Richard Purdie
> > Sent: Friday, March 16, 2012 4:50 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 6/7] python-pycurl: fix packaging
> > warnings
> > 
> > On Fri, 2012-03-16 at 12:00 -0700, nitin.a.kamble@intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > >
> > > This commit fixes these packaging warnings:
> > >  WARNING: For recipe python-pycurl, the following files/directories
> > were
> > > installed but not shipped in any package:
> > >  WARNING:   /usr/share/share
> > >
> > > PR not bumber because no change in the output packages.
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > > ---
> > >  .../python/python-pycurl_7.19.0.bb                 |    4 ++++
> > >  1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/meta/recipes-devtools/python/python-pycurl_7.19.0.bb
> > b/meta/recipes-devtools/python/python-pycurl_7.19.0.bb
> > > index d9fe465..8b849d7 100644
> > > --- a/meta/recipes-devtools/python/python-pycurl_7.19.0.bb
> > > +++ b/meta/recipes-devtools/python/python-pycurl_7.19.0.bb
> > > @@ -29,3 +29,7 @@ export STAGING_INCDIR
> > >  export STAGING_LIBDIR
> > >
> > >  BBCLASSEXTEND = "native"
> > > +
> > > +do_install_append() {
> > > +	rm -rf ${D}${datadir}/share
> > > +}
> > 
> > What is actually in there? Is that a file or a directory?
> > 
> > This is one of the cases it might be worth looking at why it exists at
> > all as something looks wrong there at a deeper level...
> > 
> That is an empty directory. Yes this need further looking why that directory existed in the 1st place.

For empty directories, at least use rmdir, then if they suddenly gain
files, we'd see a failure rather than silently still working.

Cheers,

Richard