From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] gstreamer 0.10.x: remove do_configure_prepend
Date: Wed, 21 Mar 2012 12:36:11 +0000 [thread overview]
Message-ID: <1332333371.9740.150.camel@ted> (raw)
In-Reply-To: <89c2f191e064e431f50af0b36ede86a32c76a86a.1332318835.git.liezhi.yang@windriver.com>
On Wed, 2012-03-21 at 16:38 +0800, Robert Yang wrote:
> Remove the do_configure_prepend which is used for removing
> ${S}/m4/lib-link.m4 to compile under libtool 2.2.2, but our libtool has
> been upgraded to 2.4.2, and:
>
> for the 3 recipes:
> gst-plugins-bad_0.10.22.bb
> gst-plugins-base_0.10.35.bb
> gst-plugins-good_0.10.30.bb
>
> They don't have m4/lib-link.m4 any more.
>
> For the gst-plugins-ugly_0.10.18.bb, though it has m4/lib-link.m4, our
> libtool version is now 2.4.2, so we can remove the do_configure_prepend
> from all of them.
>
> [YOCTO #2148]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> .../gstreamer/gst-plugins-bad_0.10.22.bb | 7 +------
> .../gstreamer/gst-plugins-base_0.10.35.bb | 7 +------
> .../gstreamer/gst-plugins-good_0.10.30.bb | 7 +------
> .../gstreamer/gst-plugins-ugly_0.10.18.bb | 7 +------
> 4 files changed, 4 insertions(+), 24 deletions(-)
Not so easy I'm afraid. We need to ensure our libtool is being used.
Even if the version matches, our libtool is patched to ensure the
sysroot and rpaths work correctly. I'm therefore a little nervous about
removing these at this point.
If we go through autoconf and automake and make sure our .m4 files are
used in preference to the recipe source supplied ones, I'll consider
patches like this but not until we've verified that.
Cheers,
Richard
next prev parent reply other threads:[~2012-03-21 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 8:38 [PATCH 0/1] gstreamer 0.10.x: remove do_configure_prepend Robert Yang
2012-03-21 8:38 ` [PATCH 1/1] " Robert Yang
2012-03-21 12:36 ` Richard Purdie [this message]
2012-03-21 14:45 ` Robert Yang
2012-03-30 13:24 ` Richard Purdie
2012-03-31 1:21 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332333371.9740.150.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox