From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too
Date: Fri, 23 Mar 2012 12:22:03 +0000 [thread overview]
Message-ID: <1332505323.9740.402.camel@ted> (raw)
In-Reply-To: <20120323114938.GC3879@jama.jama.net>
On Fri, 2012-03-23 at 12:49 +0100, Martin Jansa wrote:
> On Fri, Mar 23, 2012 at 11:39:53AM +0000, Richard Purdie wrote:
> > On Fri, 2012-03-23 at 10:36 +0100, Martin Jansa wrote:
> > > On Fri, Mar 23, 2012 at 09:16:33AM +0000, Richard Purdie wrote:
> > > > On Fri, 2012-03-23 at 07:43 +0100, Martin Jansa wrote:
> > > > > * /etc/modules-load.d/foo.conf is used by systemd like /etc/modutils/foo was with sysvinit
> > > > >
> > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > > ---
> > > > > meta/classes/kernel.bbclass | 10 ++++++++--
> > > > > 1 files changed, 8 insertions(+), 2 deletions(-)
> > > >
> > > > Since these look identical couldn't we symlink them? I'm not a big fan
> > > > of writing duplicate data to a package :/.
> > >
> > > OK I'll change it in v2
> >
> > Note that I'm wondering if we can just symlink the directory entirely
> > rather than the files themselves. There may be a reason that is a bad
> > idea but I don't know...
>
> There are different filenames (notice .conf in the end) so I have patch
> doing symlinks for files not directories.
I'd seen the modprobe.d conf files and thought here was some similarity.
I have to admit I think systemd is nuts for requiring a copy of these
files when it could have used the existing layout. It looks like change
for the sake of change :(.
I'm nearly tempted to suggest we should just patch systemd to use the
other filenames...
Cheers,
Richard
next prev parent reply other threads:[~2012-03-23 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 6:43 [PATCH] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too Martin Jansa
2012-03-23 9:16 ` Richard Purdie
2012-03-23 9:36 ` Martin Jansa
2012-03-23 11:39 ` Richard Purdie
2012-03-23 11:49 ` Martin Jansa
2012-03-23 12:22 ` Richard Purdie [this message]
2012-03-23 12:27 ` Koen Kooi
2012-03-23 12:30 ` Martin Jansa
2012-03-23 12:42 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332505323.9740.402.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox