From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SCDMC-000322-6K for openembedded-core@lists.openembedded.org; Mon, 26 Mar 2012 19:05:24 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2QGuOr5031362 for ; Mon, 26 Mar 2012 17:56:24 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 29204-04 for ; Mon, 26 Mar 2012 17:56:19 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q2QGuHJD031356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 26 Mar 2012 17:56:17 +0100 Message-ID: <1332780976.28414.130.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Mon, 26 Mar 2012 17:56:16 +0100 In-Reply-To: <20120326162531.GD21518@bill-the-cat> References: <1332524132-24689-1-git-send-email-trini@ti.com> <1332753313.28414.91.camel@ted> <20120326162531.GD21518@bill-the-cat> X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH] qemu.inc: Use '=' for IMAGE_FSTYPES X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 17:05:24 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2012-03-26 at 09:25 -0700, Tom Rini wrote: > On Mon, Mar 26, 2012 at 10:15:13AM +0100, Richard Purdie wrote: > > On Fri, 2012-03-23 at 10:35 -0700, Tom Rini wrote: > > > As per > > > http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019772.html > > > a machine conf file should use '=' to set IMAGE_FSTYPES. > > > > > > Signed-off-by: Tom Rini > > > --- > > > meta/conf/machine/include/qemu.inc | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > As someone pointed out, what I mentioned in that email sadly doesn't > > work although it would be nice if they did. I suspect this is why we're > > using += since: > > We aren't using += today. We (openembedded-core) use ?=. meta-intel > uses += and meta-ti is mixed (and I don't have meta-fsl-* handy). > > > > - The machine needs to say 'I need or support the following formats' > > > > so the machine ensures those formats exist at a minimum: > > > > IMAGE_FSTYPES += "xxxx" > > > > > - The distro needs to say 'I always want format X' > > > > so the distro can do: > > > > IMAGE_FSTYPES += " yyy" > > > > > - The user needs to say 'I know best, give me only format X' > > > > This one is the problem case so the user has to use overrides: > > > > IMAGE_FSTYPES_override = "X" > > > > (where override can be MACHINE or forcevariable) > > > > > - The user needs to say 'I know best, give me what you support + X' > > > > IMAGE_FSTYPES += " X" > > > > > > Whilst I think that is less than ideal since it forces use of overrides > > in local.conf to override, changing the += in machine conf files doesn't > > gain us much, it just breaks += in local.conf. > > > > I'm open to other feedback though... > > Well, I suggested ??= / ?= and posted some results from bitbake -e... Ok. += plays out as above. I realise its not what is in qemu.inc, it is used in meta-intel though which I looked at after qemu.inc and I guess has confused me. With ?= in machine.conf: The user defined IMAGE_FSTYPES would override the machine ones. Distro can still append to it. The downside is a user append would not work out as expected. So the question is which is the more user expected behaviour? =+ makes overwriting IMAGE_FSTYPES hard ?= makes appending IMAGE_FSTYPES hard I suspect a user is more likely to want to append than overwrite. Getting an append to work with ?= is extremely non-obvious, even worse syntax than the =+ overwriting case with overrides. So bottom line, I'm tempted to recommend we use =+. Further thoughts? Cheers, Richard