From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv 05/10] pixman: add native support and perl-native to DEPENDS from meta-oe
Date: Fri, 30 Mar 2012 15:43:18 +0100 [thread overview]
Message-ID: <1333118598.18082.74.camel@ted> (raw)
In-Reply-To: <20120330142210.GU25815@jama.jama.net>
On Fri, 2012-03-30 at 16:22 +0200, Martin Jansa wrote:
> On Fri, Mar 30, 2012 at 03:10:32PM +0100, Richard Purdie wrote:
> > On Fri, 2012-03-23 at 23:30 +0100, Martin Jansa wrote:
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > > meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb | 3 ++-
> > > 1 files changed, 2 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb b/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > index bf239d9..e4e3460 100644
> > > --- a/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > +++ b/meta/recipes-graphics/xorg-lib/pixman_0.25.2.bb
> > > @@ -12,7 +12,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=14096c769ae0cbb5fcb94ec468be11b3 \
> > > file://pixman/pixman-matrix.c;endline=25;md5=ba6e8769bfaaee2c41698755af04c4be \
> > > file://pixman/pixman-arm-neon-asm.h;endline=24;md5=9a9cc1e51abbf1da58f4d9528ec9d49b \
> > > "
> > > -DEPENDS += "zlib libpng"
> > > +DEPENDS += "zlib libpng perl-native"
> > > +BBCLASSEXTEND = "native"
> >
> > Er, why does this need perl-native? If it really does, the correct way
> > to do this is with "inherit perlnative" and then PATH gets set
> > correctly. I'd prefer not to add that dependency if its not needed
> > though.
>
> It was added 2 years ago
> http://git.openembedded.org/openembedded/commit/?id=c1993858d847ac17f4bd00655adf5655fd9d2c6c
>
> and it's still mandatory dep:
> configure.ac:AC_PATH_PROG(PERL, perl, no)
> configure.ac:if test "x$PERL" = xno; then
> configure.ac: AC_MSG_ERROR([Perl is required to build pixman.])
We do assume plain perl is present on the system we're building on. I'd
imagine that perl is good enough for the purposes of building pixman?
We did use to have race conditions around using the host perl which is
why we now have perlnative.bbclass. I therefore believe the dependency
is unnecessary...
Cheers,
Richard
next prev parent reply other threads:[~2012-03-30 14:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:36 [PATCH 00/13] Merge native BBCLASSEXTENDs and SDK, PACKAGECONFIG fix Martin Jansa
2012-03-21 21:36 ` [PATCH 01/13] bitbake.conf: use TUNE_PKGARCH instead of TARGET_ARCH in SDK_NAME Martin Jansa
2012-03-21 21:36 ` [PATCH 02/13] xev: move from meta-demoapps Martin Jansa
2012-03-21 21:36 ` [PATCH 03/13] classes: scons: add EXTRA_OESCONS Martin Jansa
2012-03-21 21:36 ` [PATCH 04/13] base.bbclass: extract *virtclass_map_dependencies logic from native/nativesdk bbclasses and call it from packageconfig Martin Jansa
2012-03-21 21:36 ` [PATCH 05/13] xorg: add more native BBCLASSEXTENDs for gtk+-native Martin Jansa
2012-03-21 21:36 ` [PATCH 06/13] gtk+: import native support from meta-oe Martin Jansa
2012-03-21 23:11 ` Richard Purdie
2012-03-21 23:50 ` Martin Jansa
2012-03-22 0:02 ` Richard Purdie
2012-03-22 6:51 ` Martin Jansa
2012-03-22 9:52 ` Richard Purdie
2012-03-22 10:04 ` Martin Jansa
2012-03-21 21:36 ` [PATCH 07/13] librsvg: " Martin Jansa
2012-03-21 21:36 ` [PATCH 08/13] pixman: add native support and perl-native to DEPENDS " Martin Jansa
2012-03-21 21:36 ` [PATCH 09/13] cairo: import native support " Martin Jansa
2012-03-21 21:36 ` [PATCH 10/13] tiff: " Martin Jansa
2012-03-21 21:36 ` [PATCH 11/13] libusb*: " Martin Jansa
2012-03-21 21:36 ` [PATCH 12/13] pango: import native support and --disable-introspection " Martin Jansa
2012-03-21 21:36 ` [PATCH 13/13] rootfs_ipk: replace 3 opkg-cl calls with one in get_package_filename Martin Jansa
2012-03-23 22:28 ` [PATCHv 00/10] Merge native BBCLASSEXTENDs and SDK fix Martin Jansa
2012-03-23 22:30 ` [PATCHv 01/10] bitbake.conf: use TUNE_PKGARCH instead of TARGET_ARCH in SDK_NAME Martin Jansa
2012-03-23 22:30 ` [PATCHv 02/10] xev: move from meta-demoapps Martin Jansa
2012-03-23 22:30 ` [PATCHv 03/10] classes: scons: add EXTRA_OESCONS Martin Jansa
2012-03-23 22:30 ` [PATCHv 04/10] librsvg: import native support from meta-oe Martin Jansa
2012-03-23 22:30 ` [PATCHv 05/10] pixman: add native support and perl-native to DEPENDS " Martin Jansa
2012-03-30 14:10 ` Richard Purdie
2012-03-30 14:22 ` Martin Jansa
2012-03-30 14:43 ` Richard Purdie [this message]
2012-03-23 22:30 ` [PATCHv 06/10] cairo: import native support " Martin Jansa
2012-03-23 22:30 ` [PATCHv 07/10] tiff: " Martin Jansa
2012-03-23 22:30 ` [PATCHv 08/10] libusb*: " Martin Jansa
2012-03-24 10:02 ` Richard Purdie
2012-03-24 10:56 ` Martin Jansa
2012-03-26 11:44 ` Richard Purdie
2012-03-26 12:19 ` Martin Jansa
2012-03-26 12:27 ` [PATCHv2 " Martin Jansa
2012-03-23 22:30 ` [PATCHv 09/10] pango: import native support and --disable-introspection " Martin Jansa
2012-03-23 22:30 ` [PATCHv 10/10] rootfs_ipk: replace 3 opkg-cl calls with one in get_package_filename Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333118598.18082.74.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox