Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/5] eglibc-nativesdk: Set GCC_ADDONS.
Date: Sat, 31 Mar 2012 15:11:42 +0100	[thread overview]
Message-ID: <1333203102.18082.231.camel@ted> (raw)
In-Reply-To: <eb2bbe99f15183d5c82ab5c12178a1e336a7c5ce.1333176251.git.lianhao.lu@intel.com>

On Sat, 2012-03-31 at 14:49 +0800, Lianhao Lu wrote:
> Set only necessary GCC_ADDONS for eglibc-nativesdk so that it is not
> dependant on the target eglibc's GCC_ADDONS settings.

You mean GLIBC_ADDONS, right? :)

> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
>  meta/recipes-core/eglibc/eglibc_2.13.bb |    3 ++-
>  meta/recipes-core/eglibc/eglibc_2.15.bb |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)

This is a tricky problem as this is only correct for SDKMACHINEs which
are IA based (which the only tested combinations are atm).

Ideally this would go in conf/machine-sdk/* as SDK_GLIBC_ADDONS and then
in eglibc.inc we'd do:

GLIBC_ADDONS ?= "ports,nptl,libidn"
SDK_GLIBC_ADDONS ?= "${GLIBC_ADDONS}"
GLIBC_ADDONS_virtclass-nativesdk = "${SDK_GLIBC_ADDONS}"

which I appreciate is more complex but I think its more correct in case
someone wants to try a different SDKMACHINE.

Cheers,

Richard





  reply	other threads:[~2012-03-31 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31  6:49 [PATCH 0/5] Misc fixings of nativesdk Lianhao Lu
2012-03-31  6:49 ` [PATCH 1/5] nativesdk.bbclass: Set PACKAGE_ARCHS to SDK_PACKAGE_ARCHS Lianhao Lu
2012-03-31  6:49 ` [PATCH 2/5] crosssdk.bbclass: Set TUNE_PKGARCH to SDK_PKGARCH Lianhao Lu
2012-03-31  6:49 ` [PATCH 3/5] autotools.bbclass: Drop -nativesdk dependency to lib-cross Lianhao Lu
2012-03-31  6:49 ` [PATCH 4/5] eglibc-nativesdk: Set GCC_ADDONS Lianhao Lu
2012-03-31 14:11   ` Richard Purdie [this message]
2012-03-31 14:39   ` Khem Raj
2012-03-31 14:40     ` Khem Raj
2012-04-03  0:22       ` Lu, Lianhao
2012-04-03  5:23         ` Khem Raj
2012-03-31  6:49 ` [PATCH 5/5] pkgconfig.bbclass: corrected dependency for -nativesdk Lianhao Lu
2012-03-31 17:04 ` [PATCH 0/5] Misc fixings of nativesdk Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333203102.18082.231.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox