From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: so what's the deal with "..._append +="?
Date: Mon, 02 Apr 2012 13:00:35 +0100 [thread overview]
Message-ID: <1333368035.647.28.camel@ted> (raw)
In-Reply-To: <alpine.DEB.2.02.1204020736460.9309@oneiric>
On Mon, 2012-04-02 at 07:37 -0400, Robert P. J. Day wrote:
> pretty sure i mentioned this once before but this just looks weird:
>
> $ grep -r "_append +=" *
> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
> meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> $
>
> should those be just simple assignments?
The += does add in a whitespace character. I agree it would be less
confusing if they were just plain _append = " xxx" though.
Cheers,
Richard
next prev parent reply other threads:[~2012-04-02 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 11:37 so what's the deal with "..._append +="? Robert P. J. Day
2012-04-02 12:00 ` Richard Purdie [this message]
2012-04-02 12:07 ` Robert P. J. Day
2012-04-02 12:03 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333368035.647.28.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox