Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] tune-mips32: Update the default MIPS tuning to be mips32
Date: Tue, 10 Apr 2012 13:35:15 +0100	[thread overview]
Message-ID: <1334061317.28712.121.camel@phil-desktop> (raw)
In-Reply-To: <a608dd6d5aec06056da9c20078b5cd171d6b6470.1334014014.git.mark.hatle@windriver.com>

On Mon, 2012-04-09 at 18:31 -0500, Mark Hatle wrote:
> Previously the default mips tuning was defined as "mips1"
> internally in the compiler.  Revise this and change to "mips32".
> 
> This eliminates the need for the mips32 specific tunings, which were
> not being used anyway.  (They exists and were used, but were not
> differentiated by package arch prior to a recent commit.)

This change is slightly more far-reaching than the description above
suggests, in that it isn't just changing the default tuning: it seems
actually to remove the ability to tune for pre-mips32 altogether.
Obviously there's nothing to stop anybody creating tune files for
earlier MIPS in some other BSP layer, but this is a feature that exists
in oe-core today and would be removed by this patch.

Also, the second paragraph of your checkin message above doesn't make a
lot of sense.  In the first sentence you say that the mips32 tunings
were not being used, and then in the second sentence you say that they
were.  It doesn't seem that both those statements can logically be true.

And, finally, the checkin message doesn't make it entirely clear why
this change represents an improvement, i.e. why MIPS32 is a better
default tune than MIPS I.

p.





  reply	other threads:[~2012-04-10 12:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 23:31 [PATCH 0/1] MIPS/MIPS32 tune -> MIPS Mark Hatle
2012-04-09 23:31 ` [PATCH 1/1] tune-mips32: Update the default MIPS tuning to be mips32 Mark Hatle
2012-04-10 12:35   ` Phil Blundell [this message]
2012-04-10 12:37     ` Phil Blundell
2012-04-10  0:14 ` [PATCH 0/1] MIPS/MIPS32 tune -> MIPS Andreas Oberritter
2012-04-10  0:20   ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334061317.28712.121.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox