Re: [PATCH] boost: fix re-execution of task

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2012-04-13 at 19:14 -0700, Khem Raj wrote:
> On Fri, Apr 13, 2012 at 3:23 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > On 04/13/2012 04:42 AM, Venkata ramana gollamudi wrote:
> >>
> >> After building boost package, re-execution of boostconfig task followed by
> >> re-execution of compile task is giving following error
> >> "error: duplicate initialization of gcc with the following parameters"
> >> during compilation
> >> It is because multiple entries of gcc are being added during boostconfig
> >> re-execution
> >> there by failing the compilation.
> >>
> >> The patch fixes adding multiple "Using gcc" entries into
> >> /tools/build/v2/user-config.jam
> >>
> >> [Yocto #2194]
> >>
> >> Signed-off-by: Venkata Ramana Gollamudi<ramana.gollamudi@huawei.com>
> >> ---
> >>  meta/recipes-support/boost/boost.inc |    6 +++++-
> >>  1 files changed, 5 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-support/boost/boost.inc
> >> b/meta/recipes-support/boost/boost.inc
> >> index d70a7e2..c9306df 100644
> >> --- a/meta/recipes-support/boost/boost.inc
> >> +++ b/meta/recipes-support/boost/boost.inc
> >> @@ -135,7 +135,11 @@ BJAM_OPTS    = '${BJAM_TOOLS} \
> >>  do_boostconfig() {
> >>        cp -f boost/config/platform/linux.hpp
> >> boost/config/platform/linux-gnueabi.hpp
> >>
> >> -       echo 'using gcc : 4.3.1 : ${CXX} : compileflags
> >> -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;'>>
> >>  ${S}/tools/build/v2/user-config.jam
> >> +       # D2194:Fixing the failure of "error: duplicate initialization of
> >> gcc with the following parameters" during compilation.
> >> +       if ! grep -qe "^using gcc : 4.3.1"
> >> ${S}/tools/build/v2/user-config.jam
> >> +       then
> >> +               echo 'using gcc : 4.3.1 : ${CXX} : compileflags
> >> -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;'>>
> >>  ${S}/tools/build/v2/user-config.jam
> >> +       fi
> >>  }
> >>
> >>  addtask do_boostconfig after do_patch before do_configure
> >
> >
> > Merged into OE-Core
> 
> I had some feedback on this patch series. I wonder if it was so meaningless.

I'd taken it before your feedback, the merge email was just a bit
later :(.

I'm really struggling to get fixes into the tree yet keep things
building and stable for -rc4 at the moment. I've been disappointed with
the lack of testing some patches have had. I accelerated getting some
things in so that they could get good exposure on the autobuilder at
least.

FWIW, D2194 is referencing the Yocto bugzilla, not any other internal
defect tracking system. I'll take patches to improve comments but I
really want to get some of the rebuilding issues fixed for release as
people keep hitting them and they're a pain.

Cheers,

Richard