Re: [PATCH 06/10] quilt: move empty quiltrc to native

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-04-19 at 23:23 -0700, Saul Wold wrote:
> On 04/19/2012 09:17 PM, Chris Larson wrote:
> > On Thu, Apr 19, 2012 at 3:44 PM, Saul Wold<sgw@linux.intel.com>  wrote:
> >> The package.bbclass uses the native sysroot /usr/bin/quiltrc as an empty quiltrc
> >> to ensure that the user quiltrc does not affect our patching scheme. This ensures
> >> the correct file is in the correct sysroot.
> >
> > I assume this was meant to be patch.bbclass? Aside: ${bindir} really
> > isn't where that should go, as a point for future improvement :)
> Yes, patch.bbclass references $STAGING_NATIVE_BINDIR (I think that's 
> it), Yeah, I thought about moving it, which I could still do in a second 
> patch to the native sysroot /etc or /usr/share/quilt, this might be the 
> better place.
> 
> Thoughts?

I suspect that was a workaround where quilt was picking up things it
shouldn't on a system and we needed a quiltrc file but didn't stage
sysconfdir. I think we do stage sysconfdir for native packages now and
the fact it was using /usr is just historical detail which can be
removed.

Looking at the history, we added sysconfdir 2.5 years ago in:

http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/base.bbclass?id=dfd32b429a0a9bed09b75f59f0c7fb37f42c3ed9

The quiltrc fix was from two years before that:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=95554ee9b15e575a369d9686be6af45d3a6985fc
http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/classes/patch.bbclass?id=0443d80b50e98bb329e30430bde5db67f09004e3

Regardless, lets just have one patch which moves this somewhere sensible
and makes it quilt-native only.

Cheers,

Richard