Re: [PATCH] Qt 4.8 GCC 4.7 fixes

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2012-04-27 at 12:59 +0200, Ken Werner wrote:
> This change introduces two new patches to Qt 4.8. One prevents the build
> system from using the -fuse-ld=gold GCC flag as this isn't upstream and
> therefore not supported by many toolchains out there. The second patch
> fixes a compile time error when using toolchains based on GCC 4.7.
> 
> Signed-off-by: Ken Werner <ken.werner@linaro.org>
> ---
>  meta/recipes-qt/qt4/qt-4.8.1.inc                   |    2 +
>  .../qt4/qt-4.8.1/disable-fuse-gold-flag.patch      |   26 ++++++++++++++++
>  meta/recipes-qt/qt4/qt-4.8.1/gcc47-fix.patch       |   31 ++++++++++++++++++++
>  meta/recipes-qt/qt4/qt4-embedded.inc               |    2 +-
>  4 files changed, 60 insertions(+), 1 deletions(-)
>  create mode 100644 meta/recipes-qt/qt4/qt-4.8.1/disable-fuse-gold-flag.patch
>  create mode 100644 meta/recipes-qt/qt4/qt-4.8.1/gcc47-fix.patch

Thanks, this is very timely as it happens. 

In the future could you put an "Upstream-Status:" header in any patches
which get added along with an indication of the author? This helps a lot
when you look at the patch in 12 months and wonder who wrote it (you
covered why) and also gives us an idea of which patches might be worth
prioritising to discuss with upstream. 

In this case, I've added your changes to master-next and added in the
missing patch header pieces myself. I've just been working through the
remaining gcc 4.7 issues and this looks like the main one left.

Cheers,

Richard