Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: package_rpm.bbclass: Replace shell provides/requires script with python version
Date: Fri, 27 Apr 2012 18:09:58 +0100	[thread overview]
Message-ID: <1335546598.20130.113.camel@ted> (raw)
In-Reply-To: <4F99B139.5040103@windriver.com>

On Thu, 2012-04-26 at 15:34 -0500, Mark Hatle wrote:
> On 4/26/12 2:54 PM, Richard Purdie wrote:
> > The existing shell script is a fork bomb and forks off hundreds of
> > grep/cur/wc calls as it reads from its input stream and iterates over
> > the file data table for each line of input. This patch replaces the
> > shell code with python code which doesn't exec anything and hence runs
> > much faster without the exec() overhead. This speeds up rpm packaging
> > considerably, as can be measured simply by timing it, or watching the
> > processor utilisation.
> 
> Just an FYI, the intent was to replace this code completely with a patch to RPM 
> when it got upgraded.  Then RPM could read in the dependencies directly and not 
> have to worry about hacky script solutions.
> 
> Needless to say we're not yet at that point, so this is fine..  but hopefully 
> we're getting closer.

I agree with the objective. I've had the patch lying around for a while
and in use in my builds so it was already written and doesn't seem to
regress anything. It seems to make sense to include it for now until the
rpm upgrade happens and we fix things properly.

The patch also has a partner in crime:

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t2&id=c0cbf016f59b06f461961df4d6cdfcd0928c96ee

but I suspect you'd dislike that one even if functionally it doesn't
change much at the moment.

Cheers,

Richard




  reply	other threads:[~2012-04-27 17:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 19:54 package_rpm.bbclass: Replace shell provides/requires script with python version Richard Purdie
2012-04-26 20:34 ` Mark Hatle
2012-04-27 17:09   ` Richard Purdie [this message]
2012-04-27 17:37     ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335546598.20130.113.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox