Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/7] unfs-server: Do not use DESTDIR
Date: Thu, 03 May 2012 00:09:05 +0100	[thread overview]
Message-ID: <1336000145.30113.41.camel@ted> (raw)
In-Reply-To: <0c57b76bc47680ccf576d412a3dc7e726f1daba2.1335991900.git.raj.khem@gmail.com>

On Wed, 2012-05-02 at 13:53 -0700, Khem Raj wrote:
> DESTDIR is makefile variable not available in
> bitbake environment
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../unfs-server/unfs-server_2.1+2.2beta47.bb       |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> index d03c153..682891d 100644
> --- a/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> +++ b/meta/recipes-devtools/unfs-server/unfs-server_2.1+2.2beta47.bb
> @@ -7,7 +7,7 @@ RDEPENDS_${PN} = "pseudo"
>  RDEPENDS_${PN}_virtclass-native = "pseudo-native"
>  RDEPENDS_${PN}_virtclass-nativesdk = "pseudo-nativesdk"
>  BASEPV = "2.2beta47"
> -PR = "r1"
> +PR = "r2"
>  
>  SRC_URI = "ftp://linux.mathematik.tu-darmstadt.de/pub/linux/oldstuff/people/okir/nfs-server-${BASEPV}.tar.gz \
>             file://001-2.2b47-2.2b51.patch \
> @@ -53,7 +53,7 @@ EXTRA_OECONF = "--enable-ugid-dynamic \
>                  --with-exports-uid=0 \
>                  --with-exports-gid=0 \
>                  --enable-mount-logging \
> -                --with-devtab=${DESTDIR}${base_prefix}/var/lib/nfs/devtab \
> +                --with-devtab=${base_prefix}/var/lib/nfs/devtab \

This is not correct, you want ${D} there I think. It is rather odd
though and we might be better patching the makefile for this.

Cheers,

Richard




  reply	other threads:[~2012-05-02 23:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 20:53 [PATCH 0/7] Misc fixes Khem Raj
2012-05-02 20:53 ` [PATCH 1/7] unfs-server: Do not use DESTDIR Khem Raj
2012-05-02 23:09   ` Richard Purdie [this message]
2012-05-03  0:02     ` Khem Raj
2012-05-02 20:53 ` [PATCH 2/7] xserver-xorg: Fix build on powerpc Khem Raj
2012-05-02 20:53 ` [PATCH 3/7] libatomics-ops: Make it build for SH4 Khem Raj
2012-05-03  7:50   ` Henning Heinold
2012-05-02 20:53 ` [PATCH 4/7] qemu-git: Move to tip of git Khem Raj
2012-05-02 20:53 ` [PATCH 5/7] openssl: Fix build for mips64(el) Khem Raj
2012-05-04 22:52   ` Saul Wold
2012-05-04 23:56     ` Khem Raj
2012-05-02 20:53 ` [PATCH 6/7] uclibc: Return correct endianness for mips64 Khem Raj
2012-05-02 20:54 ` [PATCH 7/7] Enable PARALLEL_MAKE for testing Khem Raj
2012-05-02 21:12   ` Paul Eggleton
2012-05-02 21:25     ` Khem Raj
2012-05-03  4:53   ` Yury Bushmelev
2012-05-04  5:54     ` Khem Raj
2012-05-04  6:10       ` Khem Raj
2012-05-04  8:11         ` Paul Eggleton
2012-05-04 14:48           ` Khem Raj
2012-05-09 23:39 ` [PATCH 0/7] Misc fixes Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336000145.30113.41.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox