Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH] connman: enable TI shared transport plugin when wifi or bluetooth are requested
Date: Sun, 06 May 2012 10:17:13 +0100	[thread overview]
Message-ID: <1336295833.23777.60.camel@ted> (raw)
In-Reply-To: <1336118046-20901-1-git-send-email-koen@dominion.thruhere.net>

On Fri, 2012-05-04 at 09:54 +0200, Koen Kooi wrote:
> This plugin manages the firmware loading for the TI wl12xx series of bluetooth/wifi/fm chips.
> 
> The double --enable-tist when both bluetooth and wireless are enabled is ugly, but harmless
> 
> The background on the plugin: https://bugs.meego.com/show_bug.cgi?id=8418
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> 
> If accepted into master I'd like to have this in the 'denzil' branch as well.
> 
>  meta/recipes-connectivity/connman/connman.inc     |    4 ++--
>  meta/recipes-connectivity/connman/connman_0.79.bb |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index bfe6620..8b27cfb 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -28,8 +28,8 @@ EXTRA_OECONF += "\
>      --enable-threads \
>      --enable-loopback \
>      --enable-ethernet \
> -    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi', '--disable-wifi', d)} \
> -    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth', '--disable-bluetooth', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi --enable-tist', '--disable-wifi', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth --enable-tist', '--disable-bluetooth', d)} \
>      --enable-dnsproxy \
>      --enable-ofono \
>      --enable-tools \
> diff --git a/meta/recipes-connectivity/connman/connman_0.79.bb b/meta/recipes-connectivity/connman/connman_0.79.bb
> index 4c57dab..d7f22b9 100644
> --- a/meta/recipes-connectivity/connman/connman_0.79.bb
> +++ b/meta/recipes-connectivity/connman/connman_0.79.bb
> @@ -11,4 +11,4 @@ SRC_URI  = "git://git.kernel.org/pub/scm/network/connman/connman.git \
>              file://test-set-ipv6-method-api-fix.patch \
>              file://connman"
>  S = "${WORKDIR}/git"
> -PR = "r3"
> +PR = "r4"

This appears to have broken the build on qemuppc:

http://autobuilder.yoctoproject.org:8010/builders/nightly-ppc/builds/369/steps/shell_19/logs/stdio

Cheers,

Richard





  parent reply	other threads:[~2012-05-06  9:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04  7:54 [PATCH] connman: enable TI shared transport plugin when wifi or bluetooth are requested Koen Kooi
2012-05-04 17:22 ` Saul Wold
2012-05-06  9:17 ` Richard Purdie [this message]
2012-05-06 12:32   ` Koen Kooi
2012-05-07  9:44     ` Richard Purdie
2012-05-07 10:02       ` Koen Kooi
2012-05-10  3:48         ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336295833.23777.60.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox