Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: Add option to oe-buildenv-internal script to change bitbake location.
Date: Mon, 21 May 2012 14:48:43 +0100	[thread overview]
Message-ID: <1337608123.22747.3.camel@ted> (raw)
In-Reply-To: <4FBA4608.6080401@balister.org>

On Mon, 2012-05-21 at 09:41 -0400, Philip Balister wrote:
> On 05/21/2012 09:25 AM, Richard Purdie wrote:
> > On Mon, 2012-05-21 at 09:07 -0400, Philip Balister wrote:
> >> On 05/09/2012 01:03 PM, Marko Lindqvist wrote:
> >>> On 9 May 2012 19:44, Philip Balister <philip@balister.org> wrote:
> >>>> Having bitbake inside the oe-core is annoying to some people. This commit
> >>>> adds a second option to the oe-init-build-env script.
> >>>>
> >>>> Run like this:
> >>>>
> >>>> . ./oe-init-build-env ../build ../bitbake
> >>>>
> >>>> for example. Without the second option, the old behavior is preserved.
> >>>>
> >>>> Signed-off-by: Philip Balister <philip@balister.org>
> >>>
> >>>  Maybe you should update comment in oe-init-build-env describing
> >>> typical use to contain this parameter.
> >>
> >> Richard, do you want me to se-send this with Marko's suggestions added?
> > 
> > I'm happy to have a follow up patch, I did merge the original. It broke
> > various assumptions being made by for example the autobuilder scripts so
> > I had to add some other changes already.
> 
> Thanks.
> 
> I'm curious how it could break things since it should not have had any
> effect unless a second argument was present.

Think about another script sourcing the internal build environment
script. You'd then see that script's second option...

Cheers,

Richard




  reply	other threads:[~2012-05-21 13:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 16:44 Add option to oe-buildenv-internal script to change bitbake location Philip Balister
2012-05-09 17:03 ` Marko Lindqvist
2012-05-21 13:07   ` Philip Balister
2012-05-21 13:25     ` Richard Purdie
2012-05-21 13:41       ` Philip Balister
2012-05-21 13:48         ` Richard Purdie [this message]
2012-05-16 18:23 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337608123.22747.3.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox