From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 5/5] busybox.inc: Install hwclock init script only if rtc is present in MACHINE_FEATURES
Date: Tue, 10 Jul 2012 17:02:34 +0100 [thread overview]
Message-ID: <1341936154.1294.3.camel@ted> (raw)
In-Reply-To: <d7e0c2813e4002b9dfd8e2d681b93da9ddc5870f.1341932186.git.andrei@gherzan.ro>
On Tue, 2012-07-10 at 17:59 +0300, Andrei Gherzan wrote:
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
> meta/recipes-core/busybox/busybox.inc | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index 82137a3..17ff442 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -180,9 +180,13 @@ do_install () {
> if grep "CONFIG_UDHCPD=y" ${WORKDIR}/defconfig; then
> install -m 0755 ${WORKDIR}/busybox-udhcpd ${D}${sysconfdir}/init.d/
> fi
> - if grep "CONFIG_HWCLOCK=y" ${WORKDIR}/defconfig; then
> - install -m 0755 ${WORKDIR}/hwclock.sh ${D}${sysconfdir}/init.d/
> - fi
> + case "${MACHINE_FEATURES}" in
> + *rtc*)
> + if grep "CONFIG_HWCLOCK=y" ${WORKDIR}/defconfig; then
> + install -m 0755 ${WORKDIR}/hwclock.sh ${D}${sysconfdir}/init.d/
> + fi
> + ;;
> + esac
> if grep "CONFIG_UDHCPC=y" ${WORKDIR}/defconfig; then
> install -d ${D}${sysconfdir}/udhcpc.d
> install -d ${D}${datadir}/udhcpc
This makes busybox machine specific? Is that really what you want to do?
Cheers,
Richard
next prev parent reply other threads:[~2012-07-10 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1341932186.git.andrei@gherzan.ro>
2012-07-10 14:59 ` [PATCH 1/5] utils.py: Modify and rename distro_features_backfill python function Andrei Gherzan
2012-07-10 14:59 ` [PATCH 2/5] bitbake.conf: Use the new form of features_backfill function Andrei Gherzan
2012-07-10 14:59 ` [PATCH 3/5] bitbake.conf: Add MACHINE_FEATURES_BACKFILL and append to MACHINE_FEATURES Andrei Gherzan
2012-07-10 14:59 ` [PATCH 4/5] bitbake.conf: Add rtc to MACHINE_FEATURES_BACKFILL Andrei Gherzan
2012-07-10 14:59 ` [PATCH 5/5] busybox.inc: Install hwclock init script only if rtc is present in MACHINE_FEATURES Andrei Gherzan
2012-07-10 16:02 ` Richard Purdie [this message]
2012-07-10 20:53 ` Andrei Gherzan
2012-07-10 22:15 ` Andrei Gherzan
2012-07-10 22:43 ` Phil Blundell
2012-07-11 9:11 ` Martin Jansa
2012-07-25 18:13 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341936154.1294.3.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox