From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path
Date: Wed, 11 Jul 2012 17:12:29 +0100 [thread overview]
Message-ID: <1342023149.11939.22.camel@ted> (raw)
In-Reply-To: <22e5e5adc39fb855badc6d1260fbd4b30d966530.1342022120.git.peter.seebach@windriver.com>
On Wed, 2012-07-11 at 11:00 -0500, Peter Seebach wrote:
> In the usual case, the computed path used for debugedit to fix
> up path references for the target filesystem is correct. However,
> prebuilt binary components, such as prebuilt toolchains, can
> have debug paths that do not reflect paths within the local
> build directory. Providing an override lets us continue to use
> the standard debugedit logic in package.bbclass.
>
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
> meta/classes/package.bbclass | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index e6856cd..1a8c7f8 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -191,6 +191,7 @@ def splitfile(file, debugfile, debugsrcdir, d):
> debugedit = d.expand("${STAGING_LIBDIR_NATIVE}/rpm/bin/debugedit")
> workdir = d.getVar("WORKDIR", True)
> workparentdir = os.path.dirname(workdir)
> + overridedir = d.getVar("DEBUGSRC_OVERRIDE_PATH", True) or ""
> sourcefile = d.expand("${WORKDIR}/debugsources.list")
I think I at least would find this slightly less confusing as:
workparentdir = d.getVar("DEBUGSRC_OVERRIDE_PATH", True) or os.path.dirname(workdir)
Cheers,
Richard
next prev parent reply other threads:[~2012-07-11 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 16:00 [PATCH 0/1] package.bbclass: Allow overriding of debugedit starting path Peter Seebach
2012-07-11 16:00 ` [PATCH 1/1] " Peter Seebach
2012-07-11 16:12 ` Richard Purdie [this message]
2012-07-11 16:33 ` Peter Seebach
2012-07-11 17:36 ` Richard Purdie
2012-07-11 17:56 ` Ross Burton
2012-07-11 18:54 ` Peter Seebach
2012-07-11 19:01 ` Chris Larson
2012-07-11 19:54 ` Burton, Ross
2012-07-11 20:20 ` Richard Purdie
-- strict thread matches above, loose matches on Subject: below --
2012-07-11 20:31 [PATCH 0/1] package.bbclass: Allow overriding of debugedit base path Peter Seebach
2012-07-11 20:31 ` [PATCH 1/1] package.bbclass: Allow overriding of debugedit starting path Peter Seebach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342023149.11939.22.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox