From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] powertop: update to 2.0+git
Date: Mon, 16 Jul 2012 10:59:22 +0100 [thread overview]
Message-ID: <1342432762.5019.9.camel@ted> (raw)
In-Reply-To: <29D9FA58-0AB0-4ADF-B67E-0541BC7DA14C@dominion.thruhere.net>
On Mon, 2012-07-16 at 08:11 +0200, Koen Kooi wrote:
> Op 15 jul. 2012, om 23:25 heeft Otavio Salvador het volgende geschreven:
>
> > On Sat, Jul 14, 2012 at 6:59 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >> The recipe is autotools based now, the COPYING file was replaced with the complete GPLv2 license text.
> >> No more 'lspci' needed ad runtime, but zlib and libnl are needed nowadays.
> >> Add 2 patches, one to fix cross builds and one from Linaro to fix C state parsing on !x86.
> >
> > Please add proper Upstream-Status for the patches; it is nice to have
> > those to track the pending patches.
>
> Isn't that field only used to put in "pending" and then backslap each
> other on doing such a good job?
I think that having the combination of knowing where the patch came
from, a description of what it does and some idea of how hacky it is
makes a significant difference to anyone subsequently looking at the
patch.
Over time I also believe we can make a significant change in the amount
of patches we're carrying around and the field will help with that.
If you want a concrete real world example now, when upgrading a recipe,
if you see the string "backport", maybe along with a commit ID, it means
you have to do much less work in verifying it is no longer required. It
also helps me review things when I see people removing patches.
Cheers,
Richard
next prev parent reply other threads:[~2012-07-16 10:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 9:59 [PATCH] powertop: update to 2.0+git Koen Kooi
2012-07-14 11:46 ` Koen Kooi
2012-07-15 21:25 ` Otavio Salvador
2012-07-16 6:11 ` Koen Kooi
2012-07-16 8:47 ` Burton, Ross
2012-07-16 10:33 ` Koen Kooi
2012-07-16 10:36 ` Paul Eggleton
2012-07-16 11:25 ` Koen Kooi
2012-07-16 12:07 ` Richard Purdie
2012-07-16 10:37 ` Burton, Ross
2012-07-16 10:44 ` Phil Blundell
2012-07-16 10:48 ` Burton, Ross
2012-07-16 9:59 ` Richard Purdie [this message]
2012-07-16 12:28 ` Otavio Salvador
2012-07-16 13:22 ` Koen Kooi
2012-07-16 13:34 ` Otavio Salvador
2012-07-16 13:40 ` Koen Kooi
2012-07-16 15:23 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342432762.5019.9.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox