From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: PLEASE READ: Major change landing shortly (python whitespace)
Date: Wed, 18 Jul 2012 12:40:18 +0100 [thread overview]
Message-ID: <1342611618.30680.24.camel@ted> (raw)
In-Reply-To: <CAJTo0LbkkXkJH-mbxwqKK7KM1PWDdF4mD+K8omTF4SQ9_WDogQ@mail.gmail.com>
On Wed, 2012-07-18 at 11:17 +0100, Burton, Ross wrote:
> On 18 July 2012 11:06, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > I put a proposal to the TSC, that we have bitbake warn/error whenever it
> > finds tab characters in any python function. The advantage of this is
> > that we give the user a clear definitive error. The downside is that
> > we'll have to go through all the metadata and scrub it for the problem.
>
> Have you ran that warning over oe-core to check that there are not any
> legitimate uses of \t, not for indentation but inside strings? I
> can't think of any realistic use but you never know (construct a
> Makefile in a python function?).
The check is for actual tab characters, not "\t". There are some
legitimate users of tab characters which I've replaced with \t in
strings.
My current patch work in progress for the conversion is:
http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t14&id=49d3d01f3d61a0eb19b6852229fa8fc26712f653
Cheers,
Richard
next prev parent reply other threads:[~2012-07-18 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 10:06 PLEASE READ: Major change landing shortly (python whitespace) Richard Purdie
2012-07-18 10:17 ` Burton, Ross
2012-07-18 11:40 ` Richard Purdie [this message]
2012-07-18 21:43 ` [bitbake-devel] " Martin Jansa
2012-07-19 8:26 ` Henning Heinold
2012-07-19 9:49 ` Martin Jansa
2012-07-19 10:15 ` Richard Purdie
2012-07-19 11:18 ` Martin Jansa
2012-07-19 11:27 ` Martin Jansa
2012-07-18 10:40 ` Martin Jansa
2012-07-18 13:11 ` Richard Purdie
2012-07-19 14:44 ` Jack Mitchell
2012-07-19 15:23 ` Martin Jansa
2012-07-20 9:38 ` Jack Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342611618.30680.24.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox