From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake: do not set CCACHE_DISABLE=0
Date: Sun, 22 Jul 2012 11:32:32 +0100 [thread overview]
Message-ID: <1342953152.21788.59.camel@ted> (raw)
In-Reply-To: <lyipdg878m.fsf@ensc-virt.intern.sigma-chemnitz.de>
On Sun, 2012-07-22 at 11:39 +0200, Enrico Scholz wrote:
> Richard Purdie
> <richard.purdie-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
> writes:
>
> >> ccache checks for existence of environment; not for its value:
> >> ...
> >> Hence, avoid setting of $CCACHE_DISABLE instead of assigning '0'.
> >
> > Why doesn't CCACHE_DISABLE[unexport] = "1" help here?
>
> You mean, keeping the
>
> | export CCACHE_DISABLE ??= "${@[0,1][d.getVar('CCACHE', True) == '']}"
>
> and requesting explicitly that user specifies
>
> | CCACHE_DISABLE[unexport] = "1"
>
> in his .conf? Sounds hacky and inconsistent and makes it impossible to
> set CCACHE_DISABLE by external environment.
The idea is that anyone enabling ccache would inherit the bbclass. The
above could therefore be simplified to a hard ??= 1 which the bbclass
resets and unexports.
> > Doesn't the unexport flag stop this entering the environment?
>
> Perhaps. In the current bitbake, 'unexport' takes precedence over
> 'export'. But is this specified somewhere and will perhaps be changed
> in a later version.
I'll happily take a patch specifying that in the bitbake manual. Other
things would break too if this changed behaviour.
Cheers,
Richard
next prev parent reply other threads:[~2012-07-22 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 11:55 [PATCH] bitbake: do not set CCACHE_DISABLE=0 Enrico Scholz
2012-07-22 8:41 ` Richard Purdie
2012-07-22 9:39 ` Enrico Scholz
2012-07-22 10:32 ` Richard Purdie [this message]
2012-07-22 11:03 ` Enrico Scholz
2012-07-22 11:39 ` Richard Purdie
2012-07-22 19:38 ` Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342953152.21788.59.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox