From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: "Ahsan, Noor" <Noor_Ahsan@mentor.com>
Subject: Re: [PATCH] dbus-glib: Conditionaly adds dbus-x11 to RDEPENDS_${PN}-tests
Date: Fri, 27 Jul 2012 17:20:02 +0100 [thread overview]
Message-ID: <1343406002.16998.1.camel@ted> (raw)
In-Reply-To: <CABcZANk5df9=C=fznO+N2Xs5+XrUgvtO0E6DqrpwxPArysFokA@mail.gmail.com>
On Fri, 2012-07-27 at 07:44 -0700, Chris Larson wrote:
> On Fri, Jul 27, 2012 at 6:10 AM, Ahsan, Noor <Noor_Ahsan@mentor.com> wrote:
> > From: Noor Ahsan <noor_ahsan@mentor.com>
> >
> > * Build was hitting an error "Nothing RPROVIDES 'dbus-x11'". dbus-glib
> > RDEPENDS on it and
> >
> > dbus was providing dbus-x11 when x11 was present in DISTRO FEATURES. So
> > conditionally
> >
> > added dbus-x11 to RDEPENDS_${PN}-tests in dbus-glib recipe.
> >
> > * Verified on qemuppc.
> >
> > Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
>
> I think this is a better fix:
>
> -PACKAGES += "${PN}-bash-completion ${PN}-tests-dbg ${PN}-tests"
> +PACKAGES += "${PN}-bash-completion ${@base_contains('PACKAGECONFIG',
> 'tests', '${PN}-tests-dbg ${PN}-tests', '', d}"
>
> Due to this:
>
> PACKAGECONFIG ??= ""
> PACKAGECONFIG[tests] = "--enable-tests,,,"
Its also worth noting that the dbus-x11 package is soon to be no more
given other patches on the mailing list.
Cheers,
Richard
prev parent reply other threads:[~2012-07-27 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 13:10 [PATCH] dbus-glib: Conditionaly adds dbus-x11 to RDEPENDS_${PN}-tests Ahsan, Noor
2012-07-27 14:44 ` Chris Larson
2012-07-27 16:20 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343406002.16998.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Noor_Ahsan@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox