From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] package_rpm.bbclass: Accomodate dash when using arrays
Date: Sun, 29 Jul 2012 14:27:05 -0700 [thread overview]
Message-ID: <1343597225-9805-1-git-send-email-raj.khem@gmail.com> (raw)
we were assigning local variable to an array coming through
positional arguments. local is a non posix contruct thats
also supported by dash luckily but operates differently in this
case it exapnds the array before assignment. so
local pkgs="$@"
turns into pkgs=locale-base-en-us locale-base-en-gb
ant we see errors
run.do_rootfs.25593: 932: local: locale-base-en-gb: bad variable name
So lets not use defining and assigning local in one go
first define a local and then the assignment
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/classes/package_rpm.bbclass | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
index b4bc52e..50e9b31 100644
--- a/meta/classes/package_rpm.bbclass
+++ b/meta/classes/package_rpm.bbclass
@@ -200,7 +200,12 @@ rpm_update_pkg () {
process_pkg_list_rpm() {
local insttype=$1
shift
- local pkgs="$@"
+ # $@ is special POSIX linear array can not be assigned
+ # to a local variable directly in dash since its separated by
+ # space and dash expands it before assignment
+ # and local x=1 2 3 and not x="1 2 3"
+ local pkgs
+ pkgs="$@"
local confbase=${INSTALL_CONFBASE_RPM}
echo -n > ${target_rootfs}/install/base_archs.pkglist
--
1.7.9.5
next reply other threads:[~2012-07-29 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 21:27 Khem Raj [this message]
2012-07-30 9:26 ` [PATCH] package_rpm.bbclass: Accomodate dash when using arrays Paul Eggleton
2012-07-30 15:27 ` Khem Raj
2012-07-31 11:22 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343597225-9805-1-git-send-email-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox