Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc-configure-target: Set native-system-header-dir for target gcc
Date: Thu, 02 Aug 2012 21:01:26 +0100	[thread overview]
Message-ID: <1343937686.9756.96.camel@ted> (raw)
In-Reply-To: <CAMKF1sr9SY=GLhKh61zzGNUZeqiAxxjFV8sZaYTki1EchVeKtA@mail.gmail.com>

On Wed, 2012-08-01 at 08:09 -0700, Khem Raj wrote:
> On Wed, Aug 1, 2012 at 1:07 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Without this set, in the case host=target (which it does for on-target
> > gcc), the native header directory is set to the target sysroot with
> > no prefix. This means it would look for sdt.h on the build system
> > instead of in the target headers and this can lead to build failures
> > and is host contamination of the build.
> >
> > The correct fix is to explicitly set the native header directory to
> > the correct location and then the headers get detected correctly.
> 
> one concern I think is what will happen to gxxinclude dir if this is
> set. if it will become relative to native headers dir as well
> I think you have to try it out the compiler on target

I tested the target compiler and couldn't find any problem. I also
checked the output of strings on the gcc binaries/libs/headers and
couldn't spot anything nasty. I've therefore merged this but we should
keep it in mind in case of problems.

Cheers,

Richard




      reply	other threads:[~2012-08-02 20:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01  8:07 [PATCH] gcc-configure-target: Set native-system-header-dir for target gcc Richard Purdie
2012-08-01 15:09 ` Khem Raj
2012-08-02 20:01   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343937686.9756.96.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox