Re: [PATCH v2 16/28] kernel.bbclass: use ${base_libdir} and ${sysconfdir} instead of /lib and /etc

Darren Hart
2012-08-06T16:28:30Z

On 08/05/2012 12:48 PM, Javier Martinez Canillas wrote:

Hi Javier,

> It is considered good practice to use the build system provided
> variables instead of directly specify hardcoded paths.

Have you tested this with a build using a base_libdir other than /lib ?

> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
> meta/classes/kernel.bbclass | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 1d8dff9..b434093 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -109,10 +109,10 @@ kernel_do_install() {
> unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
> if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
> oe_runmake DEPMOD=echo INSTALL_MOD_PATH="${D}" modules_install

The install doesn't specify base_libdir, so does the kernel make system
honor it?

> - rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.order"
> - rm -f "${D}/lib/modules/${KERNEL_VERSION}/modules.builtin"
> - rm "${D}/lib/modules/${KERNEL_VERSION}/build"
> - rm "${D}/lib/modules/${KERNEL_VERSION}/source"
> + rm -f "${D}${base_libdir}/modules/${KERNEL_VERSION}/modules.order"
> + rm -f "${D}${base_libdir}/modules/${KERNEL_VERSION}/modules.builtin"
> + rm "${D}${base_libdir}/modules/${KERNEL_VERSION}/build"
> + rm "${D}${base_libdir}/modules/${KERNEL_VERSION}/source"

if not, these will fail.

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel