From: Javier Martinez Canillas <javier@dowhile0.org>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 06/28] cronie: use variables instead of hardcoded paths
Date: Sun, 5 Aug 2012 21:48:34 +0200 [thread overview]
Message-ID: <1344196136-7643-7-git-send-email-javier@dowhile0.org> (raw)
In-Reply-To: <1344196136-7643-1-git-send-email-javier@dowhile0.org>
It is considered good practice to use the build system provided
variables instead of directly specify hardcoded paths.
Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
meta/recipes-extended/cronie/cronie_1.4.8.bb | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-extended/cronie/cronie_1.4.8.bb b/meta/recipes-extended/cronie/cronie_1.4.8.bb
index 2d25627..ce59437 100644
--- a/meta/recipes-extended/cronie/cronie_1.4.8.bb
+++ b/meta/recipes-extended/cronie/cronie_1.4.8.bb
@@ -18,7 +18,7 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_DEPS}', '', d)}"
PAM_DEPS = "libpam libpam-runtime pam-plugin-access pam-plugin-loginuid"
-PR = "r2"
+PR = "r3"
SRC_URI = "https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
file://crond.init \
@@ -61,14 +61,14 @@ do_install_append () {
# below setting is necessary to allow normal user using crontab
# setgid for crontab binary
- chown root:crontab ${D}/usr/bin/crontab
- chmod 2755 ${D}/usr/bin/crontab
+ chown root:crontab ${D}${bindir}/crontab
+ chmod 2755 ${D}${bindir}/crontab
# allow 'crontab' group write to /var/spool/cron
- chown root:crontab ${D}/var/spool/cron
- chmod 770 ${D}/var/spool/cron
+ chown root:crontab ${D}${localstatedir}/spool/cron
+ chmod 770 ${D}${localstatedir}/spool/cron
- chmod 600 ${D}/etc/crontab
+ chmod 600 ${D}${sysconfdir}/crontab
}
FILES_${PN} += "${sysconfdir}/cron*"
--
1.7.7.6
next prev parent reply other threads:[~2012-08-05 20:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 19:48 (No subject) Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 01/28] xinetd: use ${sbindir} and ${sysconfdir} instead of /usr/sbin and /etc Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 02/28] alsa-state: use ${sbindir} instead of /usr/sbin for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 03/28] lsbsetup: use ${bindir} instead of /usr/bin " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 04/28] sudo: use ${bindir} and ${sysconfdir} instead of /usr/bin and /etc Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 05/28] lsbtest: use ${bindir} instead of /usr/bin for packaging Javier Martinez Canillas
2012-08-05 19:48 ` Javier Martinez Canillas [this message]
2012-08-05 19:48 ` [PATCH v2 07/28] useradd-example: use ${datadir} instead of /usr/share " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 08/28] ubootchart: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 09/28] xkeyboard-config: use ${datadir} instead of /usr/share for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 10/28] systemtap: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 11/28] lsb: use ${base_bindir} and ${sysconfdir} instead of /bin and /etc Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 12/28] mingetty: use ${base_sbindir} instead of /sbin for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 13/28] external-sourcery: use ${prefix} and ${libdir} instead of /usr and /usr/lib Javier Martinez Canillas
2012-08-05 21:34 ` Chris Larson
2012-08-05 21:53 ` Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 14/28] rpm: use ${localstatedir} and ${libdir} instead of /var " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 15/28] at: use ${base_sbindir} instead of /sbin for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 16/28] kernel.bbclass: use ${base_libdir} and ${sysconfdir} instead of /lib and /etc Javier Martinez Canillas
2012-08-06 16:14 ` Darren Hart
2012-08-06 17:26 ` Javier Martinez Canillas
2012-08-07 20:04 ` Khem Raj
2012-08-07 20:19 ` McClintock Matthew-B29882
2012-08-05 19:48 ` [PATCH v2 17/28] linux-firware: use ${base_libdir} instead of /lib for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 18/28] openssh: use ${localstatedir} instead of /var " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 19/28] libpam: use ${localstatedir} and ${sysconfdir} instead of /var and /etc Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 20/28] x11-common: use ${sysconfdir} instead of /etc for packaging Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 21/28] builder: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 22/28] xserver-nodm-init: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 23/28] lsbinitscripts: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 24/28] usbinit: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 25/28] qemu-config: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 26/28] rsync: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 27/28] chkconfig: " Javier Martinez Canillas
2012-08-05 19:48 ` [PATCH v2 28/28] man: " Javier Martinez Canillas
2012-08-06 14:59 ` (No subject) Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344196136-7643-7-git-send-email-javier@dowhile0.org \
--to=javier@dowhile0.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox