From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 17/30] linux-firware: use ${base_libdir} instead of /lib for packaging
Date: Mon, 06 Aug 2012 19:21:56 +0100 [thread overview]
Message-ID: <1344277316.4874.2.camel@x121e.pbcl.net> (raw)
In-Reply-To: <50200899.7000500@linux.intel.com>
On Mon, 2012-08-06 at 11:10 -0700, Darren Hart wrote:
> On 08/05/2012 08:54 AM, Javier Martinez Canillas wrote:
> > It is considered good practice to use the build system provided
> > variables instead of directly specify hardcoded paths.
>
> The firmware location is explicitly set because this is where the Linux
> kernel requires it to be.
Is that actually true? I thought the kernel just supplied the leafname
that it wanted and the knowledge about what directory to search was
encoded in the hotplug helper scripts.
> This patch will break firmware loading.
That might well be the case, though, unless the scripts have also been
patched to respect ${base_libdir}.
And, notwithstanding all the above, it's not entirely obvious that
${base_libdir} is semantically the right variable for things that aren't
libraries. How does the udev recipe represent the patch to /lib/udev?
p.
next prev parent reply other threads:[~2012-08-06 18:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 15:53 [PATCH 00/30] cleanup: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 01/30] xinetd: use ${sbindir} instead of /usr/sbin for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 02/30] alsa-state: " Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 03/30] lsbsetup: use ${bindir} instead of /usr/bin " Javier Martinez Canillas
2012-08-06 17:25 ` Mark Hatle
2012-08-05 15:53 ` [PATCH 04/30] sudo: use ${bindir} and ${sysconfdir} instead of /usr/bin and /etc Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 05/30] lsbtest: use ${bindir} instead of /usr/bin for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 06/30] cronie: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 07/30] useradd-example: use ${datadir} instead of /usr/share for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 08/30] ubootchart: use variables instead of hardcoded paths Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 09/30] xkeyboard-config: use ${datadir} instead of /usr/share for packaging Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 10/30] systemtap: " Javier Martinez Canillas
2012-08-05 15:53 ` [PATCH 11/30] lsb: use ${base_bindir} instead of /bin " Javier Martinez Canillas
2012-08-06 17:29 ` Mark Hatle
2012-08-05 15:53 ` [PATCH 12/30] mingetty: use ${base_sbindir} instead of /sbin " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 13/30] external-sourcery: use ${prefix} and ${libdir} instead of /usr and /usr/lib Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 14/30] rpm: use ${localstatedir} and ${libdir} instead of /var " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 15/30] at: use ${base_sbindir} instead of /sbin for packaging Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 16/30] kernel.bbclass: use ${base_libdir} and ${sysconfdir} instead of /lib and /etc Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 17/30] linux-firware: use ${base_libdir} instead of /lib for packaging Javier Martinez Canillas
2012-08-06 18:10 ` Darren Hart
2012-08-06 18:21 ` Phil Blundell [this message]
2012-08-07 16:14 ` Darren Hart
2012-08-07 18:29 ` Koen Kooi
2012-08-05 15:54 ` [PATCH 18/30] openssh: use ${localstatedir} instead of /var " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 19/30] libpam: use ${localstatedir} and ${sysconfdir} instead of /var and /etc Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 20/30] x11-common: use ${sysconfdir} instead of /etc for packaging Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 21/30] lsb: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 22/30] builder: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 23/30] xserver-nodm-init: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 24/30] lsbinitscripts: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 25/30] xinetd: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 26/30] usbinit: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 27/30] qemu-config: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 28/30] rsync: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 29/30] chkconfig: " Javier Martinez Canillas
2012-08-05 15:54 ` [PATCH 30/30] man: " Javier Martinez Canillas
2012-08-05 18:16 ` [PATCH 00/30] cleanup: use variables instead of hardcoded paths Otavio Salvador
2012-08-05 19:10 ` Khem Raj
2012-08-05 19:19 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344277316.4874.2.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox