Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Andrei Gherzan <andrei.gherzan@windriver.com>
Subject: Re: [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror
Date: Thu, 16 Aug 2012 12:28:27 +0100	[thread overview]
Message-ID: <1345116507.14667.51.camel@ted> (raw)
In-Reply-To: <1345116093-5872-1-git-send-email-andrei.gherzan@windriver.com>

On Thu, 2012-08-16 at 14:21 +0300, Andrei Gherzan wrote:
> After commit 2718537b4b04eb3d80ab4d74171b58e7b8dd68b8 (bitbake:
> build.py: Only execute mkdirhier if stampdir doesn't exist) build
> failes as cached_mtime_noerror needs an argument - stamp dir. This
> argument was forgotten.
> 
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
>  bitbake/lib/bb/build.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/bitbake/lib/bb/build.py b/bitbake/lib/bb/build.py
> index d64077e..b484d19 100644
> --- a/bitbake/lib/bb/build.py
> +++ b/bitbake/lib/bb/build.py
> @@ -465,7 +465,7 @@ def stamp_internal(taskname, d, file_name):
>      stamp = bb.parse.siggen.stampfile(stamp, file_name, taskname, extrainfo)
>  
>      stampdir = os.path.dirname(stamp)
> -    if bb.parse.cached_mtime_noerror == 0:
> +    if bb.parse.cached_mtime_noerror(stampdir) == 0:
>          bb.utils.mkdirhier(stampdir)
>  
>      return stamp

I suspect I'd fixed this locally but pushed an old version. I've merged
this, thanks.

Richard




  reply	other threads:[~2012-08-16 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 11:21 [PATCH] bitbake: build.py: Add stampdir argument to cached_mtime_noerror Andrei Gherzan
2012-08-16 11:28 ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-16 11:17 Andrei Gherzan
2012-08-16 17:33 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345116507.14667.51.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=andrei.gherzan@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox