From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T2J9o-00080D-Ux for openembedded-core@lists.openembedded.org; Fri, 17 Aug 2012 11:47:57 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7H9Zu3m007281; Fri, 17 Aug 2012 10:35:56 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06130-08; Fri, 17 Aug 2012 10:35:52 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7H9ZlC0007275 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Fri, 17 Aug 2012 10:35:48 +0100 Message-ID: <1345196146.14667.84.camel@ted> From: Richard Purdie To: Liang Li Date: Fri, 17 Aug 2012 10:35:46 +0100 In-Reply-To: <20120817033209.GB19625@localhost> References: <1344008589-3660-1-git-send-email-liang.li@windriver.com> <1344348160.9756.255.camel@ted> <20120808033742.GA19078@localhost> <20120814021712.GB25748@localhost> <502D12E2.4000808@windriver.com> <1345132684.14667.70.camel@ted> <20120817033209.GB19625@localhost> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: darren.hart@intel.com, openembedded-core@lists.openembedded.org Subject: Re: [discussion] perf: specify SLANG_INC dir for perf X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2012 09:47:57 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2012-08-17 at 11:32 +0800, Liang Li wrote: > On 2012-08-16 23:58, Richard Purdie wrote: > > On Thu, 2012-08-16 at 11:33 -0400, Bruce Ashfield wrote: > > > On 12-08-13 10:17 PM, Liang Li wrote: > > > > Hi Richard, > > > > > > > > Ping ... > > > > > > > > Hopefully you could recall sufficient context from this thread about > > > > the 'include path for slang.h' cause compile error issue that we are > > > > trying to fix here. > > > > > > Bump. > > > > > > I'm holding off on merging a kernel patch for this while this is still > > > outstanding. > > > > > > Can I distill this into the following (in the hope of resolving it). > > > > > > - do we want to fix this problem for all kernels, or just the linux-yocto > > > ones ? And by 'fix', I mean without the requirement of porting > > > a kernel patch to older recipes. > > > > I propose we add a sed expression to the general kernel do_install which > > changes the -I/usr/include/slang -> -I=/usr/include/slang. That should > > be generic, acceptable to upstream and fixes all kernel versions. > > > > Comments? > > > > Good advise, so the kernel patch can be revised to: > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile > index 067f2df..071986c 100644 > --- a/tools/perf/Makefile > +++ b/tools/perf/Makefile > @@ -497,7 +497,7 @@ else > BASIC_CFLAGS += -DNO_NEWT_SUPPORT > else > # Some releases like Fedora has /usr/include/slang/slang.h other than /usr/include/slang.h > - SLANG_INC ?= -I/usr/include/slang > + SLANG_INC ?= -idirafter /usr/include/slang > BASIC_CFLAGS += $(SLANG_INC) > > EXTLIBS += -lnewt -lslang Why do you need a kernel patch at all with the solution I mentioned above? > With this, we might not have to touch perf.bb. So seems like we'll use > this solution? :) You should need to add the sed to the general kernel do_install. We should also get this fixed upstream in the mainline kernel. We shouldn't need a kernel patch or any recipe change to perf. Cheers, Richard