From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] base.bbclass: Work even when there's no PNBLACKLIST entries
Date: Fri, 17 Aug 2012 10:54:15 +0100 [thread overview]
Message-ID: <1345197255.26132.3.camel@ted> (raw)
In-Reply-To: <71f45133289f617d85d0c9072ea3b4d584f5de67.1345135594.git.peter.seebach@windriver.com>
On Thu, 2012-08-16 at 11:50 -0500, Peter Seebach wrote:
> It turns out that the result of getVarFlags is not a list, it's
> a dict. So "getVarFlags(...) or []" does not reliably produce
> something with a .items. This escaped detection because our
> local build environment never ends up running builds without
> PNBLACKLIST entries.
>
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
> meta/classes/base.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 840ddbc..acc3217 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -175,7 +175,7 @@ def preferred_ml_updates(d):
>
> versions = []
> providers = []
> - blacklists = d.getVarFlags('PNBLACKLIST') or []
> + blacklists = d.getVarFlags('PNBLACKLIST') or {}
> for v in d.keys():
> if v.startswith("PREFERRED_VERSION_"):
> versions.append(v)
Merged to master, thanks.
Richard
prev parent reply other threads:[~2012-08-17 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 16:50 [PATCH 0/1] Correct blacklist-related build errors Peter Seebach
2012-08-16 16:50 ` [PATCH 1/1] base.bbclass: Work even when there's no PNBLACKLIST entries Peter Seebach
2012-08-17 9:54 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345197255.26132.3.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox