From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T2KQ7-00029P-2K for openembedded-core@lists.openembedded.org; Fri, 17 Aug 2012 13:08:51 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7HAurpw008068 for ; Fri, 17 Aug 2012 11:56:53 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 07451-06 for ; Fri, 17 Aug 2012 11:56:49 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q7HAukEg008062 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 17 Aug 2012 11:56:47 +0100 Message-ID: <1345201006.26132.21.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Fri, 17 Aug 2012 11:56:46 +0100 In-Reply-To: References: <92d6de11744098c3431309c5abc2f3217e166dac.1345174354.git.laurentiu.palcu@intel.com> <1345196331.14667.86.camel@ted> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net X-MIME-Autoconverted: from 8bit to quoted-printable by tim.rpsys.net id q7HAurpw008068 Subject: Re: [PATCH 3/3] adt-installer: add support for relocatable SDK X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2012 11:08:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-08-17 at 12:42 +0200, Andreas M=C3=BCller wrote: > On Fri, Aug 17, 2012 at 11:38 AM, Richard Purdie > wrote: > > On Fri, 2012-08-17 at 06:44 +0300, Laurentiu Palcu wrote: > >> Since we made the SDK relocatable, we have to add this functionality= to > >> adt-installer too. > >> > >> Other: > >> - Changed tabs to spaces in the recipe file too. > > > > Shell functions use tabs, python uses spaces. The OE TSC has thought > > long and hard about this and that is the decision. Its not perfect bu= t > > the alternatives will cause more problems than any benefit is worth. > Is there some report/log/styleguide helping me to understand why we > use two tab/space strategies instead of having spaces for all? This is the style the bulk of the metadata uses. We really don't want patches changing a significant portion of the metadata for cosmetic reasons. It would create a world of pain for people handling/merging patches, a lot of needless code churn and significant problems for people trying to backport changes to older versions of the code base amongst other reasons. Cheers, Richard