Re: [PATCH 4/8] mesa: enable GLES v1 and v2

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2012-08-13 at 19:58 +0100, Ross Burton wrote:
> Patch originally by Damien Lespiau <damien.lespiau@intel.com>.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-graphics/mesa/mesa-common.inc |   12 ++++++++++--
>  meta/recipes-graphics/mesa/mesa-dri.inc    |    2 ++
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-graphics/mesa/mesa-common.inc b/meta/recipes-graphics/mesa/mesa-common.inc
> index aac3bbe..24cc3d0 100644
> --- a/meta/recipes-graphics/mesa/mesa-common.inc
> +++ b/meta/recipes-graphics/mesa/mesa-common.inc
> @@ -12,7 +12,7 @@ SECTION = "x11"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://docs/license.html;md5=03ccdc4c379c4289aecfb8892c546f67"
>  
> -INC_PR = "r0"
> +INC_PR = "r1"
>  PE = "2"
>  
> 
> @@ -21,7 +21,7 @@ LIB_DEPS = "virtual/libx11 libxext libxxf86vm libxdamage libxfixes libxml2-nativ
>  
>  DEPENDS = "makedepend-native flex-native bison-native ${PROTO_DEPS} ${LIB_DEPS}"
>  
> -PROVIDES = "virtual/libgl"
> +PROVIDES = "virtual/libgl virtual/libgles1 virtual/libgles2"
>  
>  # for mesa-dri and mesa-xlib
>  FILESEXTRAPATHS_append := "${THISDIR}/mesa:"
> @@ -34,6 +34,8 @@ EXTRA_OECONF = "--enable-glu \
>                  --enable-glx-tls \
>                  --enable-shared-glapi"
>  
> +PACKAGECONFIG ??= "${@base_contains('MACHINE_FEATURES', 'x86', 'gles', '', d)}"


I've taken this but could we change this to:

PACKAGECONFIG ??= ""
PACKAGECONFIG_x86 ?= "gles"

since I'd prefer to rely on the architecture override than the
MACHINE_FEATURES. This recipe shouldn't be machine specific if we can
help it.

Cheers,

Richard