From: Matthew McClintock <msm@freescale.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] kmod-native_git.bb: fix builds for hosts with older libc
Date: Mon, 20 Aug 2012 13:49:23 -0500 [thread overview]
Message-ID: <1345488563-30901-1-git-send-email-msm@freescale.com> (raw)
kmod will fail to build with the following error because O_CLOEXEC is
not defined:
| libkmod/libkmod-module.c: In function 'kmod_module_get_initstate':
| libkmod/libkmod-module.c:1640: error: 'O_CLOEXEC' undeclared (first use in this function)
| libkmod/libkmod-module.c:1640: error: (Each undeclared identifier is reported only once
| libkmod/libkmod-module.c:1640: error: for each function it appears in.)
| libkmod/libkmod-module.c: In function 'kmod_module_get_refcnt':
| libkmod/libkmod-module.c:1754: error: 'O_CLOEXEC' undeclared (first use in this function)
| libkmod/libkmod-module.c: In function 'kmod_module_get_sections':
| libkmod/libkmod-module.c:1913: error: 'O_CLOEXEC' undeclared (first use in this function)
| libkmod/libkmod-file.c: In function 'kmod_file_open':
| libkmod/libkmod-file.c:282: error: 'O_CLOEXEC' undeclared (first use in this function)
| libkmod/libkmod-file.c:282: error: (Each undeclared identifier is reported only once
| libkmod/libkmod-file.c:282: error: for each function it appears in.)
Since we are only using kmod-native for depmod, and it's a non-threaded
user of this libary being built this should be safe to override O_CLOEXEC.
Keep in mind this is ONLY effecting the native builds and not what is
being shipped in the root file system.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
meta/recipes-kernel/kmod/kmod-native_git.bb | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/kmod/kmod-native_git.bb b/meta/recipes-kernel/kmod/kmod-native_git.bb
index 96de8b8..3c5e3c3 100644
--- a/meta/recipes-kernel/kmod/kmod-native_git.bb
+++ b/meta/recipes-kernel/kmod/kmod-native_git.bb
@@ -4,7 +4,7 @@
require kmod.inc
inherit native
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
do_install_append (){
for tool in depmod insmod lsmod modinfo modprobe rmmod
@@ -12,3 +12,9 @@ do_install_append (){
ln -s kmod ${D}${bindir}/$tool
done
}
+
+do_compile_append (){
+ if ! grep O_CLOEXEC -r ${includedir_native}/bits/fcntl.h; then
+ export CFLAGS="$CFLAGS -D O_CLOEXEC=0"
+ fi
+}
--
1.7.9.7
next reply other threads:[~2012-08-20 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 18:49 Matthew McClintock [this message]
2012-08-20 20:39 ` [PATCH] kmod-native_git.bb: fix builds for hosts with older libc Chris Larson
2012-08-21 10:49 ` Richard Purdie
2012-08-21 16:20 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345488563-30901-1-git-send-email-msm@freescale.com \
--to=msm@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox