Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andy Ross <andy.ross@windriver.com>
To: openembedded-core@openembedded.org
Subject: [PATCH 1/2] libtool: update rpath normalization to use builtin
Date: Thu, 23 Aug 2012 10:32:30 -0700	[thread overview]
Message-ID: <1345743151-2065-2-git-send-email-andy.ross@windriver.com> (raw)
In-Reply-To: <1345743151-2065-1-git-send-email-andy.ross@windriver.com>

Use the built-in normalization function instead of the sed hack.

Signed-off-by: Andy Ross <andy.ross@windriver.com>
---
 meta/recipes-devtools/libtool/libtool-2.4.2.inc    |  2 +-
 .../libtool/libtool/norm-rpath.patch               | 22 ++++++++--------------
 2 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
index 691427e..95e12a2 100644
--- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
+++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
@@ -8,7 +8,7 @@ LICENSE = "GPLv2 & LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
     file://libltdl/COPYING.LIB;md5=e3eda01d9815f8d24aae2dbd89b68b06"
 
-INC_PR = "r4"
+INC_PR = "r5"
 
 SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://trailingslash.patch \
diff --git a/meta/recipes-devtools/libtool/libtool/norm-rpath.patch b/meta/recipes-devtools/libtool/libtool/norm-rpath.patch
index 03a7667..dce1576 100644
--- a/meta/recipes-devtools/libtool/libtool/norm-rpath.patch
+++ b/meta/recipes-devtools/libtool/libtool/norm-rpath.patch
@@ -7,33 +7,27 @@ RPATH in the generated binary.  Normalize before comparision.
 Signed-off-by: Andy Ross <andy.ross@windriver.com>
 Upstream-Status: Pending
 
-diff -ru a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
+diff -ur a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
 --- a/libltdl/config/ltmain.m4sh	2012-08-16 13:58:55.058900363 -0700
-+++ b/libltdl/config/ltmain.m4sh	2012-08-16 16:34:54.616627821 -0700
-@@ -7288,8 +7288,13 @@
++++ b/libltdl/config/ltmain.m4sh	2012-08-22 11:01:34.191345989 -0700
+@@ -7288,8 +7288,10 @@
  	      else
                  # We only want to hardcode in an rpath if it isn't in the
                  # default dlsearch path.
-+                libdir_norm=`echo $libdir \
-+                  | sed 's/\/\+\.\(\/\+\|$\)/\//g' \
-+                  | sed 's/[^\/]\+\/\+\.\.\(\/\+\|$\)//g' \
-+                  | sed 's/\/\+/\//g' \
-+                  | sed 's/\(.\)\/$/\1/g'`
++                func_normal_abspath "$libdir"
++                libdir_norm=$func_normal_abspath_result
  	        case " $sys_lib_dlsearch_path " in
 -	        *" $libdir "*) ;;
 +	        *" $libdir_norm "*) ;;
  	        *) eval flag=\"$hardcode_libdir_flag_spec\"
                     func_append dep_rpath " $flag"
                     ;;
-@@ -8027,8 +8032,13 @@
+@@ -8027,8 +8029,10 @@
  	  else
              # We only want to hardcode in an rpath if it isn't in the
              # default dlsearch path.
-+            libdir_norm=`echo $libdir \
-+              | sed 's/\/\+\.\(\/\+\|$\)/\//g' \
-+              | sed 's/[^\/]\+\/\+\.\.\(\/\+\|$\)//g' \
-+              | sed 's/\/\+/\//g' \
-+              | sed 's/\(.\)\/$/\1/g'`
++            func_normal_abspath "$libdir"
++            libdir_norm=$func_normal_abspath_result
  	    case " $sys_lib_dlsearch_path " in
 -	    *" $libdir "*) ;;
 +	    *" $libdir_norm "*) ;;
-- 
1.7.11.4




  reply	other threads:[~2012-08-23 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 17:32 [PATCH 0/2] RPATH fixes: libtool & binutils Andy Ross
2012-08-23 17:32 ` Andy Ross [this message]
2012-08-23 17:32   ` [PATCH 2/2] ld: -rpath must search under sysroot Andy Ross
2012-08-24 18:40 ` [PATCH 0/2] RPATH fixes: libtool & binutils Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345743151-2065-2-git-send-email-andy.ross@windriver.com \
    --to=andy.ross@windriver.com \
    --cc=openembedded-core@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox