From: Phil Blundell <philb@gnu.org>
To: Mark Asselstine <mark.asselstine@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] base-files: provide a mechanism to skip creation of the hostname file
Date: Tue, 28 Aug 2012 19:38:04 +0100 [thread overview]
Message-ID: <1346179084.4396.6.camel@x121e.pbcl.net> (raw)
In-Reply-To: <1346178028-2036-1-git-send-email-mark.asselstine@windriver.com>
On Tue, 2012-08-28 at 14:20 -0400, Mark Asselstine wrote:
> + if [ "${hostname}" != "none" ]; then
This magic string value seems a bit unwholesome. Can't you just check
against the empty string?
Also, if the problem is that the static hostname set here is overriding
the one from dhcp or the command line, I wonder whether this just
indicates that the priority of them is wrong and the scripting should be
adjusted so that the static file has lower priority than the other two
things.
p.
next prev parent reply other threads:[~2012-08-28 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 18:20 [PATCH V2] base-files: provide a mechanism to skip creation of the hostname file Mark Asselstine
2012-08-28 18:38 ` Phil Blundell [this message]
2012-08-28 18:53 ` Mark Asselstine
2012-08-28 19:16 ` Burton, Ross
2012-08-28 20:01 ` Mark Asselstine
2012-08-28 20:11 ` Burton, Ross
2012-08-30 17:20 ` Mark Asselstine
2012-09-07 18:09 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346179084.4396.6.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=mark.asselstine@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox