From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] sanity.bbclass: Move back to running at ConfigParsed time
Date: Wed, 05 Sep 2012 23:42:53 +0100 [thread overview]
Message-ID: <1346884973.21985.137.camel@ted> (raw)
In-Reply-To: <CABcZANk+N+3Gg3kASaQ_19DYd_AtyDoWsS-hfv=mFZe0Jaz6Qg@mail.gmail.com>
On Wed, 2012-09-05 at 15:21 -0700, Chris Larson wrote:
> On Wed, Sep 5, 2012 at 7:27 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > If we don't do this, users can get extremely confused errors since the sanity tests
> > happen too late (after parsing) and don't see the warnings.
>
> Can you elaborate on this? This commit message is extremely unclear.
> If there's an open bug in bugzilla or something that could be referred
> to here, that'd be helpful.
Sorry, I should have elaborated.
Set an invalid MACHINE, try and build and you set all kinds of nasty
warnings and no sensible message about what is wrong.
Change LCONF_VERSION and you don't get the warning unless parsing
completes which it may or may not depending on the kind of change.
and so on.
The sanity.bbclass code is meant to be helpful in these scenarios and
when its most needed, it wasn't working.
FWIW, I think we do need to fix the way sanity is being triggered and
improve this (massively). Unfortunately I didn't have time to do that
right this second but lets file an enhancement request in the bugzilla
and lets see if we can improve things soon?
Cheers,
Richard
next prev parent reply other threads:[~2012-09-05 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 14:27 [PATCH] sanity.bbclass: Move back to running at ConfigParsed time Richard Purdie
2012-09-05 22:21 ` Chris Larson
2012-09-05 22:42 ` Richard Purdie [this message]
2012-09-05 22:49 ` Chris Larson
2012-09-11 6:39 ` Martin Jansa
2012-09-11 9:43 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346884973.21985.137.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox