From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] packagegroup-core-x11: split machine specific parts to separate recipe packagegroup-core-x11-server
Date: Fri, 07 Sep 2012 00:37:10 +0100 [thread overview]
Message-ID: <1346974630.7493.39.camel@ted> (raw)
In-Reply-To: <20120906233413.GB3487@jama.jama.net>
On Fri, 2012-09-07 at 01:34 +0200, Martin Jansa wrote:
> On Fri, Sep 07, 2012 at 12:29:59AM +0100, Richard Purdie wrote:
> > On Tue, 2012-09-04 at 22:58 +0200, Martin Jansa wrote:
> > > * add new packagegroup-core-x11-server to SIGGEN_EXCLUDERECIPES_ABISAFE,
> > > so that recipes depending on it are not rebuilt after every machine
> > > swtich
> > > * allows to remove task-x11-server and task-x11 from meta-oe without
> > > loosing any functionality
> > > * be carefull with default XSERVER value which does not have
> > > xf86-input-mouse and xf86-input-keyboard)
> > > * VIRTUAL-RUNTIME_xserver_common which defaults to x11-common in oe-core
> > > and xserver-common in meta-oe's task-x11
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > > meta/conf/layer.conf | 1 +
> > > .../packagegroups/packagegroup-core-x11-xserver.bb | 24 ++++++++++++++++++++++
> > > .../packagegroups/packagegroup-core-x11.bb | 16 ++-------------
> > > 3 files changed, 27 insertions(+), 14 deletions(-)
> > > create mode 100644 meta/recipes-graphics/packagegroups/packagegroup-core-x11-xserver.bb
> >
> > This sneaked in with a load of other patches. I never meant to merge
> > this as I consider it broken.
> >
> > Task packages are cheap and having them being machine specific imposes
> > little overhead. Splitting this into two just increases the parsing
> > overhead through the number of recipes and doesn't do much else since
> > there are still machine specific packages involved, all dependencies
> > still get built etc. so I really don't see the point of the added
> > complexity.
>
> Yes task-* are cheap but if such recipe is in RDEPENDS of some other
> more expensive recipe then it's better when it's excluded from sstate.
Which expensive recipes RDEPEND on task/packagegroup recipes?
Cheers,
Richard
prev parent reply other threads:[~2012-09-06 23:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 20:58 [PATCH 1/2] packagegroup-core-x11: add upgrade path from meta-oe task-x11* Martin Jansa
2012-09-04 20:58 ` [PATCH 2/2] packagegroup-core-x11: split machine specific parts to separate recipe packagegroup-core-x11-server Martin Jansa
2012-09-06 23:29 ` Richard Purdie
2012-09-06 23:34 ` Martin Jansa
2012-09-06 23:37 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346974630.7493.39.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox