From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] autotools.bbclass: Add functionality to force a distclean when reconfiguring
Date: Fri, 07 Sep 2012 17:05:43 +0100 [thread overview]
Message-ID: <1347033943.8619.0.camel@ted> (raw)
Unfortunately whilst reruning configure and make against a project will mostly
work there are situations where it does not correctly do the right thing.
In particular, eglibc and gcc will fail out with errors where settings
do not match a previously built configuration. It could be argued they are
broken but the situation is what it is. There is the possibility of more subtle
errors too.
This patch adds a "make distclean" call to recipes where configure is
rerunning and the sstate checksum for do_configure has changed. We could
simply use a stamp but saving out the previous configuration checksum
adds some data at no real overhead.
If we find there are things out there which don't have a "distclean" target,
we can disable this behaviour with CONFIGURESTAMPFILE = "" in the recipe,
or users could disable it globally.
[YOCTO #2774]
[YOCTO #2848]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 4c4bf87..1ab2e0c 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -89,7 +89,16 @@ oe_runconf () {
AUTOTOOLS_AUXDIR ?= "${S}"
+CONFIGURESTAMPFILE = "${WORKDIR}/configure.sstate"
+
autotools_do_configure() {
+ if [ -n "${CONFIGURESTAMPFILE}" -a -e "${CONFIGURESTAMPFILE}" ]; then
+ if [ "`cat ${CONFIGURESTAMPFILE}`" != "${BB_TASKHASH}" ]; then
+ echo "Previously configured build detected, running make distclean"
+ oe_runmake distclean
+ fi
+ fi
+
case ${PN} in
autoconf*)
;;
@@ -180,6 +189,9 @@ autotools_do_configure() {
else
bbnote "nothing to configure"
fi
+ if [ -n "${CONFIGURESTAMPFILE}" ]; then
+ echo ${BB_TASKHASH} > ${CONFIGURESTAMPFILE}
+ fi
}
autotools_do_install() {
next reply other threads:[~2012-09-07 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 16:05 Richard Purdie [this message]
2012-09-07 16:32 ` [PATCH] autotools.bbclass: Add functionality to force a distclean when reconfiguring Mark Hatle
2012-09-07 16:37 ` Richard Purdie
2012-09-07 16:42 ` Burton, Ross
2012-09-07 17:09 ` Richard Purdie
2012-09-07 17:15 ` Phil Blundell
2012-09-08 8:05 ` Khem Raj
2012-09-08 13:30 ` Mark Hatle
2012-09-08 15:36 ` Colin Walters
2012-09-08 15:44 ` Colin Walters
2012-09-08 15:49 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347033943.8619.0.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox