From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.pbcl.net ([88.198.119.4] helo=hetzner.pbcl.net)
	by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <philb@gnu.org>) id 1TG74g-0000QR-9A
	for openembedded-core@lists.openembedded.org;
	Mon, 24 Sep 2012 13:43:42 +0200
Received: from elite.brightsigndigital.co.uk ([81.142.160.137]
	helo=[172.30.1.145])
	by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.72) (envelope-from <philb@gnu.org>)
	id 1TG6sH-0004OF-KF; Mon, 24 Sep 2012 13:30:53 +0200
From: Phil Blundell <philb@gnu.org>
To: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Date: Mon, 24 Sep 2012 12:30:52 +0100
In-Reply-To: <1348485983-8294-1-git-send-email-andrei.adrianx.dinu@intel.com>
References: <1348485983-8294-1-git-send-email-andrei.adrianx.dinu@intel.com>
X-Mailer: Evolution 3.0.2- 
Message-ID: <1348486253.31293.28.camel@phil-desktop>
Mime-Version: 1.0
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: Fix for dynamic linker broken offset
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Sep 2012 11:43:42 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Mon, 2012-09-24 at 14:26 +0300, Andrei Dinu wrote:
> +-	    *reloc_addr += sym->st_value;
> ++	    *reloc_addr = sym->st_value;

That patch looks slightly dubious to me.  Are you sure this doesn't
introduce any regressions elsewhere?

p.