From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TGUjW-0000iR-E7 for openembedded-core@lists.openembedded.org; Tue, 25 Sep 2012 14:59:26 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q8PCkabZ008142; Tue, 25 Sep 2012 13:46:36 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 07280-03; Tue, 25 Sep 2012 13:46:32 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id q8PCkRYb008136 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Tue, 25 Sep 2012 13:46:28 +0100 Message-ID: <1348577188.8662.53.camel@ted> From: Richard Purdie To: Martin Jansa Date: Tue, 25 Sep 2012 13:46:28 +0100 In-Reply-To: <20120925123652.GI3295@jama.jama.net> References: <1348570313-16920-1-git-send-email-Martin.Jansa@gmail.com> <1348575933.8662.48.camel@ted> <20120925123652.GI3295@jama.jama.net> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Cc: openembedded-core@lists.openembedded.org Subject: Re: [RFC][PATCH] linux-yocto: drop machine from SRCREV_FORMAT X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 12:59:26 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2012-09-25 at 14:36 +0200, Martin Jansa wrote: > On Tue, Sep 25, 2012 at 01:25:33PM +0100, Richard Purdie wrote: > > On Tue, 2012-09-25 at 12:51 +0200, Martin Jansa wrote: > > > * otherwise LOCALCOUNT is incremented after each MACHINE switch when > > > machine usually has different SRCREV (e.g. because of different KBRANCH) > > > * see http://lists.linuxtogo.org/pipermail/openembedded-core/2012-September/029392.html > > > > > > Signed-off-by: Martin Jansa > > > --- > > > meta/recipes-kernel/linux/linux-yocto.inc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc > > > index 973970d..6efb578 100644 > > > --- a/meta/recipes-kernel/linux/linux-yocto.inc > > > +++ b/meta/recipes-kernel/linux/linux-yocto.inc > > > @@ -16,7 +16,7 @@ LINUX_KERNEL_TYPE ?= "standard" > > > # KMETA ?= "" > > > KBRANCH ?= "master" > > > KMACHINE ?= "${MACHINE}" > > > -SRCREV_FORMAT ?= "meta_machine" > > > +SRCREV_FORMAT ?= "meta" > > > > > > LINUX_VERSION_EXTENSION ?= "-yocto-${LINUX_KERNEL_TYPE}" > > > > No, absolutely not. I have discussed this with Bruce before and there > > are no guarantees that the meta branch gets updated whenever machine > > changes. This is necessary to have deterministic builds and correctness > > of sstate for example. > > Isn't SRCREV_FORMAT used only to construct PV? So builds are still > deterministic because SRCREV is still locked to same value? PV is what triggers the system to rebuild. So if its not included, rebuilds won't happen when the revisions change. > Also PV which keeps changing without any change in source or metadata > doesn't look deterministic to me. I agree there is a problem, this is just not the right way to fix it, the problem is elsewhere, likely in the git fetcher. Making the revisions in the sqlite database respect components of STAMP/WORKDIR is probably the way we'll end up having to fix this (so some database entries are machine specific, some arch specific, some allarch). Cheers, Richard