Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gcc-common.inc: Consider multilib when renaming libgcc for debian'ness
Date: Tue, 25 Sep 2012 22:53:42 +0100	[thread overview]
Message-ID: <1348610022.8662.70.camel@ted> (raw)
In-Reply-To: <5061F3F1.2010502@windriver.com>

On Tue, 2012-09-25 at 13:12 -0500, Mark Hatle wrote:
> On 9/24/12 5:24 PM, Khem Raj wrote:
> > When doing multilib builds rpm does not find libgcc1 for lib32
> > multilib because its not honoring the debian renaming scheme for
> > libgcc-multilib. Lets add MLPREFIX to fix it.
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >   meta/recipes-devtools/gcc/gcc-common.inc |    2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
> > index 3b00017..38f3b7f 100644
> > --- a/meta/recipes-devtools/gcc/gcc-common.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-common.inc
> > @@ -40,7 +40,7 @@ def get_gcc_multiarch_setting(bb, d):
> >   # For now, libgcc is most important so we fix for that - RP.
> >   SHLIBSDIR = "${STAGING_DIR_TARGET}/shlibs"
> >
> > -DEBIANNAME_libgcc = "libgcc1"
> > +DEBIANNAME_${MLPREFIX}libgcc = "libgcc1"
> 
> I realize this is a fairly rare case, but should the debian (or multilib) 
> bbclasses be multilib aware, and if so automatically generate the corresponding 
> DEBIANNAME_${MLPREFIX}pn = value?
> 
> This is already done for blacklists, preferred provider/version and whitelists 
> in the base.bbclass.  Then if anyone (in the future) specifies DEBIANNAME, it'll 
> be automatic.

The multilib/package code does have a list of variables it processes for
this, this one should probably be added to that list.

In fact debian.bbclass should append it to the list package.bbclass
has...

Cheers,

Richard




      reply	other threads:[~2012-09-25 22:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 22:24 [PATCH] gcc-common.inc: Consider multilib when renaming libgcc for debian'ness Khem Raj
2012-09-25  9:42 ` Richard Purdie
2012-09-25 18:07   ` McClintock Matthew-B29882
2012-09-26 10:55     ` Richard Purdie
2012-09-28 18:31       ` McClintock Matthew-B29882
2012-09-25 18:12 ` Mark Hatle
2012-09-25 21:53   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348610022.8662.70.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox