From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.pbcl.net ([88.198.119.4] helo=hetzner.pbcl.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1THXRi-00055U-0z for openembedded-core@lists.openembedded.org; Fri, 28 Sep 2012 12:05:22 +0200 Received: from elite.brightsigndigital.co.uk ([81.142.160.137] helo=[172.30.1.145]) by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1THXFH-0000fH-9o; Fri, 28 Sep 2012 11:52:31 +0200 From: Phil Blundell To: Andrei Dinu Date: Fri, 28 Sep 2012 10:52:30 +0100 In-Reply-To: <506054A0.6090309@intel.com> References: <1348485983-8294-1-git-send-email-andrei.adrianx.dinu@intel.com> <1348486253.31293.28.camel@phil-desktop> <506054A0.6090309@intel.com> X-Mailer: Evolution 3.0.2- Message-ID: <1348825951.32611.30.camel@phil-desktop> Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] eglibc: Fix for dynamic linker broken offset X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2012 10:05:22 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2012-09-24 at 15:40 +0300, Andrei Dinu wrote: > On 09/24/2012 02:30 PM, Phil Blundell wrote: > > On Mon, 2012-09-24 at 14:26 +0300, Andrei Dinu wrote: > >> +- *reloc_addr += sym->st_value; > >> ++ *reloc_addr = sym->st_value; > > That patch looks slightly dubious to me. Are you sure this doesn't > > introduce any regressions elsewhere? > > > > > I have insufficient data to affirm that it doesn't introduces regressions. Presumably it does at least pass the eglibc and binutils testsuites, right? p.