Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] SDK: trap any IO errors in the relocate script
Date: Fri, 28 Sep 2012 16:46:36 +0100	[thread overview]
Message-ID: <1348847196.15753.56.camel@ted> (raw)
In-Reply-To: <5065489E.6060802@intel.com>

On Fri, 2012-09-28 at 09:50 +0300, Laurentiu Palcu wrote:
> 
> On 09/27/2012 06:49 PM, Saul Wold wrote:
> > On 09/25/2012 09:35 AM, Laurentiu Palcu wrote:
> > 
> > BTW: in the future it's good to say the "filename: <commit subject>"
> This is what I usually use when I change single files. However,
> sometimes (and I know this particular patch is not the case), I change
> multiple files to fix a single problem or add a feature. In this case
> your BKM is not quite appropriate. I will end up with a commit subject
> like this:
> 
> filename1, filename2, filename3: <no space left for the subject itself>
> 
> If those files belong to a certain functional area, say SDK, I thought
> it was more appropriate to prepend the subject with SDK.
> 
> Also, the contribution guidelines on the wiki, state the same (see rpm
> example):
> 
> https://wiki.yoctoproject.org/wiki/Contribution_Guidelines
> 
> Am I wrong here?

No but I think "SDK" is just a little unspecific so for example a hint
that this was a change to "scripts:"  would have been more useful which
I think was Saul's point.

Cheers,

Richard




      reply	other threads:[~2012-09-28 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 16:35 [PATCH] SDK: trap any IO errors in the relocate script Laurentiu Palcu
2012-09-27 15:49 ` Saul Wold
2012-09-28  6:50   ` Laurentiu Palcu
2012-09-28 15:46     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348847196.15753.56.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=laurentiu.palcu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox